Re: [PATCH] relayfs redux, part 4

2005-02-10 Thread Andi Kleen
> > Please consider inlining alloc_page_array() and populate_page_array() > into relay_alloc_rchan_buf() as they're only used once. You'd get rid > of passing page_count as a pointer this way. If inlining is > unacceptable, please at least move the n_pages calculation to > relay_alloc_rchan_buf()

Re: [PATCH] relayfs redux, part 4

2005-02-09 Thread Pekka Enberg
On Wed, 9 Feb 2005 20:49:36 -0600, Tom Zanussi <[EMAIL PROTECTED]> wrote: > +static int relayfs_create_entry(const char *name, struct dentry *parent, > + int mode, struct rchan *chan, > + struct dentry **dentry) > +{ > + struct qstr

Re: [PATCH] relayfs redux, part 4

2005-02-09 Thread Pekka Enberg
Hi Tom, On Wed, 9 Feb 2005 20:49:36 -0600, Tom Zanussi <[EMAIL PROTECTED]> wrote: > +static inline struct page **alloc_page_array(int size, int *page_count) > +{ > + int n_pages; > + struct page **page_array; > + > + size = PAGE_ALIGN(size); > + n_pages = size >> PAGE_SHIFT

Re: [PATCH] relayfs redux, part 4

2005-02-09 Thread Tom Zanussi
Maneesh Soni writes: > On Wed, Feb 09, 2005 at 08:49:36PM -0600, Tom Zanussi wrote: > [..] > > + */ > > +struct dentry *relayfs_create_file(const char *name, struct dentry > > *parent, > > + int mode, struct rchan *chan) > > +{ > > + struct dentry *dentry; > >

Re: [PATCH] relayfs redux, part 4

2005-02-09 Thread Maneesh Soni
On Wed, Feb 09, 2005 at 08:49:36PM -0600, Tom Zanussi wrote: [..] > + */ > +struct dentry *relayfs_create_file(const char *name, struct dentry *parent, > +int mode, struct rchan *chan) > +{ > + struct dentry *dentry; > + int error; > + > + if (!mode)

[PATCH] relayfs redux, part 4

2005-02-09 Thread Tom Zanussi
Hi, Here's the latest relayfs patch, incorporating the previous round of suggestions. Thanks to everyone who sent comments. Here's a list of the major changes: - replaced remap_page_range() and reserved bits with a nopage() handler. - buffers are now allocated/freed as part of inode alloc/des