Re: [PATCH] relay-file-read-start-pos-fix.patch

2007-06-21 Thread David Wilder
Ack Works for me. Thanks. Note: Both Masami's patch and the relay-file-read-start-pos-fix.patch I posted earlier are required. Masami Hiramatsu wrote: Hi Tom, Tom Zanussi wrote: Could you send more info on how to reproduce the problem you're seeing? And does this patch fix it? S

Re: [PATCH] relay-file-read-start-pos-fix.patch

2007-06-20 Thread Tom Zanussi
On Wed, 2007-06-20 at 17:31 +0900, Masami Hiramatsu wrote: [...] > P.S. > I attached my patch (relay-file-read-overwrite-mode-fix.patch) > which fixed the problem pointed in previous mail. > > Signed-off-by: Masami Hiramatsu <[EMAIL PROTECTED]> > Hi, Thanks for sending the test case. I wrote

Re: [PATCH] relay-file-read-start-pos-fix.patch

2007-06-20 Thread Masami Hiramatsu
Hi Tom, Tom Zanussi wrote: > Could you send more info on how to reproduce the problem you're seeing? > And does this patch fix it? Sure, I'll explain how to reproduce it. Since current SystemTap is not supporting "overwrite" mode, you need to apply a patch before trying to reproduce it. I alread

Re: [PATCH] relay-file-read-start-pos-fix.patch

2007-06-19 Thread Masami Hiramatsu
Tom Zanussi wrote: > Hi, > > I haven't had a chance to test it myself yet, but it looks ok to me, > except for one problem noted below... Hi, Thank you so much! I'm preparing how it can reproduce. I'll send it as soon as possible. > Thanks for fixing it. > >> Signed-off-by: Masami Hiramatsu <[

Re: [PATCH] relay-file-read-start-pos-fix.patch

2007-06-19 Thread Tom Zanussi
On Tue, 2007-06-19 at 12:43 +0900, Masami Hiramatsu wrote: > Hi David and Tom, > > David Wilder wrote: > > This patch fixes a bug in the relay read interface causing the number > > of consumed bytes to be set incorrectly. > > Thank you. Your patch fixes one of my concerns. > However there is ano

Re: [PATCH] relay-file-read-start-pos-fix.patch

2007-06-18 Thread Tom Zanussi
On Tue, 2007-06-19 at 12:43 +0900, Masami Hiramatsu wrote: > Hi David and Tom, > > David Wilder wrote: > > This patch fixes a bug in the relay read interface causing the number > > of consumed bytes to be set incorrectly. > > Thank you. Your patch fixes one of my concerns. > However there is ano

Re: [PATCH] relay-file-read-start-pos-fix.patch

2007-06-18 Thread Masami Hiramatsu
Hi David and Tom, David Wilder wrote: > This patch fixes a bug in the relay read interface causing the number > of consumed bytes to be set incorrectly. Thank you. Your patch fixes one of my concerns. However there is another bug I found. When I use relayfs with "overwrite" mode, read() still se

[PATCH] relay-file-read-start-pos-fix.patch

2007-06-17 Thread David Wilder
-- David Wilder IBM Linux Technology Center Beaverton, Oregon, USA [EMAIL PROTECTED] (503)578-3789 This patch fixes a bug in the relay read interface causing the number of consumed bytes to be set incorrectly. Signed-off-by: Tom Zanussi <[EMAIL PROTECTED]> Signed-off-by: David Wilder <[EMAIL