Re: [PATCH] reiserfs: don't drop PG_dirty when releasing sub-page-sized dirty file

2007-10-23 Thread Fengguang Wu
On Tue, Oct 23, 2007 at 12:17:51PM +0200, Maxim Levitsky wrote: > > --- > > fs/reiserfs/stree.c |3 --- > > 1 file changed, 3 deletions(-) > > > > --- linux-2.6.24-git17.orig/fs/reiserfs/stree.c > > +++ linux-2.6.24-git17/fs/reiserfs/stree.c > > @@ -1458,9 +1458,6 @@ static void unmap_buffers

Re: [PATCH] reiserfs: don't drop PG_dirty when releasing sub-page-sized dirty file

2007-10-23 Thread Fengguang Wu
On Tue, Oct 23, 2007 at 10:10:53AM -0400, Chris Mason wrote: > On Tue, 23 Oct 2007 19:56:20 +0800 > Fengguang Wu <[EMAIL PROTECTED]> wrote: > > > On Tue, Oct 23, 2007 at 12:07:07PM +0200, Peter Zijlstra wrote: > > > [ adding reiserfs devs to the CC ] > > > > Thank you. > > > > This fix is kind o

Re: [PATCH] reiserfs: don't drop PG_dirty when releasing sub-page-sized dirty file

2007-10-23 Thread Chris Mason
On Tue, 23 Oct 2007 19:56:20 +0800 Fengguang Wu <[EMAIL PROTECTED]> wrote: > On Tue, Oct 23, 2007 at 12:07:07PM +0200, Peter Zijlstra wrote: > > [ adding reiserfs devs to the CC ] > > Thank you. > > This fix is kind of crude - even when it fixed Maxim's problem, and > survived my stress testing

Re: [PATCH] reiserfs: don't drop PG_dirty when releasing sub-page-sized dirty file

2007-10-23 Thread Fengguang Wu
On Tue, Oct 23, 2007 at 12:07:07PM +0200, Peter Zijlstra wrote: > [ adding reiserfs devs to the CC ] Thank you. This fix is kind of crude - even when it fixed Maxim's problem, and survived my stress testing of a lot of patching and kernel compiling. I'd be glad to see better solutions. Fengguang

Re: [PATCH] reiserfs: don't drop PG_dirty when releasing sub-page-sized dirty file

2007-10-23 Thread Maxim Levitsky
On Tuesday 23 October 2007 09:55:14 Fengguang Wu wrote: > This is not a new problem in 2.6.23-git17. > 2.6.22/2.6.23 is buggy in the same way. > > Reiserfs could leave newly created sub-page-size files in dirty state > for ever. They cannot be synced to disk by pdflush routines or > explicit `syn

Re: [PATCH] reiserfs: don't drop PG_dirty when releasing sub-page-sized dirty file

2007-10-23 Thread Peter Zijlstra
[ adding reiserfs devs to the CC ] On Tue, 2007-10-23 at 15:55 +0800, Fengguang Wu wrote: > This is not a new problem in 2.6.23-git17. > 2.6.22/2.6.23 is buggy in the same way. > > Reiserfs could leave newly created sub-page-size files in dirty state > for ever. They cannot be synced to disk by

[PATCH] reiserfs: don't drop PG_dirty when releasing sub-page-sized dirty file

2007-10-23 Thread Fengguang Wu
This is not a new problem in 2.6.23-git17. 2.6.22/2.6.23 is buggy in the same way. Reiserfs could leave newly created sub-page-size files in dirty state for ever. They cannot be synced to disk by pdflush routines or explicit `sync' commands. Only `umount' can do the trick. The direct cause is: