On Tue, May 28, 2013 at 05:10:00AM -0700, Chao Xie wrote:
Please fix your mail client to word wrap within paragraphs.
> Thanks for your review.
> Because structure regulator_desc only accepts the voltage table as constant.
> struct regulator_desc {
> ...
> const unsigned int *volt_tab
> -Original Message-
> From: Mark Brown [mailto:broo...@kernel.org]
> Sent: Tuesday, May 28, 2013 6:04 PM
> To: yi zhang
> Cc: Liam Girdwood; Chao Xie; jett.z...@marvell.com;
> linux-kernel@vger.kernel.org; Yi Zhang
> Subject: Re: [PATCH] regulator: 88pm800: add reg
On Tue, May 28, 2013 at 10:32:09AM +0800, yi zhang wrote:
> HI, Brown:
In western culture it's either "Hi Mark" or "Hi Mr Brown" (though the
latter is pretty formal so not used much for things like mailing lists).
> Sorry I'm a little confused:
> You mean I should use a funct
HI, Brown:
2013/5/26 Mark Brown :
> On Fri, May 24, 2013 at 11:01:45AM +0800, yi zhang wrote:
>> 2013/5/23 Mark Brown :
>> > On Wed, May 22, 2013 at 08:10:53PM +0800, yizhang.m...@gmail.com wrote:
>
>> >> +static const unsigned int BUCK1_table[] = {
>> >> + /* 0x00-0x4F: from 0.6 to 1.5875V wi
On Fri, May 24, 2013 at 11:01:45AM +0800, yi zhang wrote:
> 2013/5/23 Mark Brown :
> > On Wed, May 22, 2013 at 08:10:53PM +0800, yizhang.m...@gmail.com wrote:
> >> +static const unsigned int BUCK1_table[] = {
> >> + /* 0x00-0x4F: from 0.6 to 1.5875V with step 0.0125V */
> >> + /* 0x50-0x7F
Hi, Brown:
2013/5/23 Mark Brown :
> On Wed, May 22, 2013 at 08:10:53PM +0800, yizhang.m...@gmail.com wrote:
>
> You need a DT binding document for any new DT bindings like this one.
>
Thanks for your comments, I'll do it;
>> +static const unsigned int BUCK1_table[] = {
>> + /* 0x00-0x4F: from
On Wed, May 22, 2013 at 08:10:53PM +0800, yizhang.m...@gmail.com wrote:
You need a DT binding document for any new DT bindings like this one.
> +static const unsigned int BUCK1_table[] = {
> + /* 0x00-0x4F: from 0.6 to 1.5875V with step 0.0125V */
> + /* 0x50-0x7F: from 1.6 to 1.8V with s
From: Yi Zhang
Signed-off-by: Yi Zhang
---
drivers/regulator/88pm800.c | 531 +++
drivers/regulator/Kconfig | 10 +
drivers/regulator/Makefile |1 +
3 files changed, 542 insertions(+), 0 deletions(-)
create mode 100644 drivers/regulator/88pm800
8 matches
Mail list logo
