Re: [PATCH] regulator/core.c: remove the else statement

2017-04-19 Thread Mark Brown
On Wed, Apr 19, 2017 at 08:53:05PM +0800, Biaoyong Hu wrote: > kfree(pin); pin will be freed. So, "pin->request_count = 0;" should be > removed? Yes, it's redundant. Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and unde

Re: [PATCH] regulator/core.c: remove the else statement

2017-04-18 Thread Joe Perches
On Tue, 2017-04-18 at 16:49 +0100, Mark Brown wrote: > On Tue, Apr 18, 2017 at 11:39:34PM +0800, hubiaoyong wrote: > > in the function regulator_ena_gpio_free, the if branch contains > > the return statement, so remove the else statement. > > Why is it a benefit to make this change? In general, r

Re: [PATCH] regulator/core.c: remove the else statement

2017-04-18 Thread Mark Brown
On Tue, Apr 18, 2017 at 11:39:34PM +0800, hubiaoyong wrote: > in the function regulator_ena_gpio_free, the if branch contains > the return statement, so remove the else statement. Why is it a benefit to make this change? signature.asc Description: PGP signature

[PATCH] regulator/core.c: remove the else statement

2017-04-18 Thread hubiaoyong
in the function regulator_ena_gpio_free, the if branch contains the return statement, so remove the else statement. Signed-off-by: hubiaoyong --- drivers/regulator/core.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.