Re: [PATCH] regmap: mmio: Fix value endianness selection

2016-03-28 Thread Stefan Agner
On 2016-03-28 23:10, Alexander Stein wrote: > On Friday 25 March 2016 11:24:59, Mark Brown wrote: >> On Wed, Mar 23, 2016 at 03:20:46PM +0100, Alexander Stein wrote: >> > The difference in those drivers is that syscon manually sets >> > config.val_format_endian before calling regmap_init_mmio. >> >

Re: [PATCH] regmap: mmio: Fix value endianness selection

2016-03-28 Thread Alexander Stein
On Friday 25 March 2016 11:24:59, Mark Brown wrote: > On Wed, Mar 23, 2016 at 03:20:46PM +0100, Alexander Stein wrote: > > The difference in those drivers is that syscon manually sets > > config.val_format_endian before calling regmap_init_mmio. > > spi-fsl-dspi does not. I guess this driver relies

Re: [PATCH] regmap: mmio: Fix value endianness selection

2016-03-25 Thread Mark Brown
On Wed, Mar 23, 2016 at 03:20:46PM +0100, Alexander Stein wrote: > The difference in those drivers is that syscon manually sets > config.val_format_endian before calling regmap_init_mmio. > spi-fsl-dspi does not. I guess this driver relies on this configuration being > done in regmap_get_val_end

Re: [PATCH] regmap: mmio: Fix value endianness selection

2016-03-23 Thread Alexander Stein
On Wednesday 23 March 2016 13:17:59, Mark Brown wrote: > Currently when selecting value endianness we check the register > endiannes, not the value endianness. > > Reported-by: Alexander Stein > Signed-off-by: Mark Brown Mh, while this _does_ fix the problem regarding accessing SCFG peripheral

Re: [PATCH] regmap: mmio: Fix value endianness selection

2016-03-23 Thread Alexander Stein
On Wednesday 23 March 2016 13:17:59, Mark Brown wrote: > Currently when selecting value endianness we check the register > endiannes, not the value endianness. > > Reported-by: Alexander Stein > Signed-off-by: Mark Brown > --- Tested-by: Alexander Stein Thanks and best regards, Alexander

[PATCH] regmap: mmio: Fix value endianness selection

2016-03-23 Thread Mark Brown
Currently when selecting value endianness we check the register endiannes, not the value endianness. Reported-by: Alexander Stein Signed-off-by: Mark Brown --- drivers/base/regmap/regmap-mmio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/regmap/regmap-mmio.c