Re: [PATCH] rds: ib: force endiannes annotation

2019-04-29 Thread Christoph Hellwig
On Mon, Apr 29, 2019 at 01:18:36PM +0200, Nicholas Mc Guire wrote: > changing uncongested to __le64 is not an option here - it would only move > the sparse warnings to those other locatoins where the ports that > became uncongested are being or'ed into uncongested. Than fix that a well. Either b

Re: [PATCH] rds: ib: force endiannes annotation

2019-04-29 Thread Edward Cree
On 29/04/2019 12:18, Nicholas Mc Guire wrote: > On Mon, Apr 29, 2019 at 12:00:06PM +0100, Edward Cree wrote: >> Again, a __force cast doesn't seem necessary here.  It looks like the >>  code is just using the wrong types; if all of src, dst and uncongested >>  were __le64 instead of uint64_t, and t