RE: [PATCH] rdma: move the ib_wr_opcode enum to include/uapi

2018-09-19 Thread Nikolova, Tatyana E
Hi Jason, > > What is the correct way for a user space application to check whether > > a NIC supports SEND_WITH_INVAL? We are currently examining the > > device_cap_flags in the structure returned by ibv_query_device. > > Specifically, we're looking at IBV_DEVICE_MEM_MGT_EXTENSIONS. > However, >

RE: [PATCH] rdma: move the ib_wr_opcode enum to include/uapi

2018-09-17 Thread Howell, Seth
ib_wr_opcode enum to include/uapi > >From e3c1b1b81373601fa6cbad2ba5fadd2c8cfdfaed Mon Sep 17 00:00:00 > >2001 > From: Seth Howell > Date: Tue, 14 Aug 2018 15:33:02 -0700 > Subject: [PATCH] IB/rxe: Revise the ib_wr_opcode enum > > This enum has become part of th

Re: [PATCH] rdma: move the ib_wr_opcode enum to include/uapi

2018-09-17 Thread Jason Gunthorpe
> >From e3c1b1b81373601fa6cbad2ba5fadd2c8cfdfaed Mon Sep 17 00:00:00 2001 > From: Seth Howell > Date: Tue, 14 Aug 2018 15:33:02 -0700 > Subject: [PATCH] IB/rxe: Revise the ib_wr_opcode enum > > This enum has become part of the uABI, as both RXE and the > ib_uverbs_post_send() command expect users

Re: [PATCH] rdma: move the ib_wr_opcode enum to include/uapi

2018-09-17 Thread Jason Gunthorpe
On Mon, Sep 17, 2018 at 10:29:18PM +, Walker, Benjamin wrote: > On Mon, 2018-09-17 at 15:08 -0600, Jason Gunthorpe wrote: > > On Mon, Sep 17, 2018 at 08:38:16PM +, Walker, Benjamin wrote: > > > We've recently run into this same issue on i40iw, which appears to make > > > the > > > same > >

Re: [PATCH] rdma: move the ib_wr_opcode enum to include/uapi

2018-09-17 Thread Walker, Benjamin
On Mon, 2018-09-17 at 15:08 -0600, Jason Gunthorpe wrote: > On Mon, Sep 17, 2018 at 08:38:16PM +, Walker, Benjamin wrote: > > We've recently run into this same issue on i40iw, which appears to make the > > same > > mistake of using the kernel version of the enum instead of the userspace > > ver

Re: [PATCH] rdma: move the ib_wr_opcode enum to include/uapi

2018-09-17 Thread Jason Gunthorpe
ow...@vger.kernel.org [mailto: > > linux-rdma-ow...@vger.kernel.org] On Behalf Of Jason Gunthorpe > > Sent: Thursday, August 16, 2018 11:01 AM > > To: Howell, Seth > > Cc: Walker, Benjamin ; Doug Ledford < > > dledf...@redhat.com>; linux-r...@vger.kernel.org; &g

Re: [PATCH] rdma: move the ib_wr_opcode enum to include/uapi

2018-09-17 Thread Walker, Benjamin
Sent: Thursday, August 16, 2018 11:01 AM > To: Howell, Seth > Cc: Walker, Benjamin ; Doug Ledford < > dledf...@redhat.com>; linux-r...@vger.kernel.org; linux-kernel@vger.kernel.org > ; Moni Shoua > Subject: Re: [PATCH] rdma: move the ib_wr_opcode enum to include/uapi > > On

RE: [PATCH] rdma: move the ib_wr_opcode enum to include/uapi

2018-08-20 Thread Howell, Seth
-kernel@vger.kernel.org; Moni Shoua Subject: Re: [PATCH] rdma: move the ib_wr_opcode enum to include/uapi On Wed, Aug 15, 2018 at 11:27:36PM +, Howell, Seth wrote: > Thank you for taking the time to review this issue. The patch you > submitted will definitely fix the problem I was facing

Re: [PATCH] rdma: move the ib_wr_opcode enum to include/uapi

2018-08-16 Thread Jason Gunthorpe
On Wed, Aug 15, 2018 at 11:27:36PM +, Howell, Seth wrote: > Thank you for taking the time to review this issue. The patch you > submitted will definitely fix the problem I was facing. Can you test it to be certain? Thanks, Jason

RE: [PATCH] rdma: move the ib_wr_opcode enum to include/uapi

2018-08-15 Thread Howell, Seth
; linux-r...@vger.kernel.org; linux-kernel@vger.kernel.org; Moni Shoua Subject: Re: [PATCH] rdma: move the ib_wr_opcode enum to include/uapi On Tue, Aug 14, 2018 at 03:33:02PM -0700, Seth Howell wrote: > By making this enum accessible to the userspace API, we can avoid > conflicts between the

Re: [PATCH] rdma: move the ib_wr_opcode enum to include/uapi

2018-08-15 Thread Jason Gunthorpe
On Tue, Aug 14, 2018 at 03:33:02PM -0700, Seth Howell wrote: > By making this enum accessible to the userspace API, we can avoid > conflicts between the kernel-space ib_wr_opcode and the user-space > ibv_wr_opcode enums. > > When using the rxe software driver interface between kernel and user > sp

[PATCH] rdma: move the ib_wr_opcode enum to include/uapi

2018-08-14 Thread Seth Howell
By making this enum accessible to the userspace API, we can avoid conflicts between the kernel-space ib_wr_opcode and the user-space ibv_wr_opcode enums. When using the rxe software driver interface between kernel and user space, the enum value IBV_WR_SEND_WITH_INV was being improperly translated