Re: [PATCH] rbd: Remove VLA stack usage

2018-03-12 Thread Ilya Dryomov
On Mon, Mar 12, 2018 at 6:06 AM, Tobin C. Harding wrote: > On Sun, Mar 11, 2018 at 10:02:04PM -0700, Eric Biggers wrote: >> On Mon, Mar 12, 2018 at 03:49:40PM +1100, Tobin C. Harding wrote: >> > The kernel would like to have all stack VLA usage removed[1]. >> >> Can you please stop writing this?

Re: [PATCH] rbd: Remove VLA stack usage

2018-03-11 Thread Tobin C. Harding
On Sun, Mar 11, 2018 at 10:02:04PM -0700, Eric Biggers wrote: > On Mon, Mar 12, 2018 at 03:49:40PM +1100, Tobin C. Harding wrote: > > The kernel would like to have all stack VLA usage removed[1]. > > Can you please stop writing this? The Linux kernel isn't sentient; it doesn't > "like" anything.

Re: [PATCH] rbd: Remove VLA stack usage

2018-03-11 Thread Eric Biggers
On Mon, Mar 12, 2018 at 03:49:40PM +1100, Tobin C. Harding wrote: > The kernel would like to have all stack VLA usage removed[1]. Can you please stop writing this? The Linux kernel isn't sentient; it doesn't "like" anything. You need to explain why *you* (and other people) believe these changes

[PATCH] rbd: Remove VLA stack usage

2018-03-11 Thread Tobin C. Harding
The kernel would like to have all stack VLA usage removed[1]. Here the array is declared using a variable that is declared using a constant statement but the compiler still emits a warning. We can clear the warning bu using the constant statement directly. In place of later usage of the size var