Re: [PATCH] random: fix the RNDRESEEDCRNG ioctl

2021-01-11 Thread Jann Horn
On Mon, Jan 4, 2021 at 7:55 PM Eric Biggers wrote: > On Fri, Nov 20, 2020 at 10:52:14AM -0800, Eric Biggers wrote: > > On Mon, Oct 26, 2020 at 09:33:43AM -0700, Eric Biggers wrote: > > > On Tue, Oct 06, 2020 at 08:50:21PM -0700, Eric Biggers wrote: > > > > On Tue, Sep 15, 2020 at 09:19:08PM -0700,

Re: [PATCH] random: fix the RNDRESEEDCRNG ioctl

2021-01-04 Thread Eric Biggers
On Fri, Nov 20, 2020 at 10:52:14AM -0800, Eric Biggers wrote: > On Mon, Oct 26, 2020 at 09:33:43AM -0700, Eric Biggers wrote: > > On Tue, Oct 06, 2020 at 08:50:21PM -0700, Eric Biggers wrote: > > > On Tue, Sep 15, 2020 at 09:19:08PM -0700, Eric Biggers wrote: > > > > From: Eric Biggers > > > > >

Re: [PATCH] random: fix the RNDRESEEDCRNG ioctl

2020-11-20 Thread Eric Biggers
On Mon, Oct 26, 2020 at 09:33:43AM -0700, Eric Biggers wrote: > On Tue, Oct 06, 2020 at 08:50:21PM -0700, Eric Biggers wrote: > > On Tue, Sep 15, 2020 at 09:19:08PM -0700, Eric Biggers wrote: > > > From: Eric Biggers > > > > > > The RNDRESEEDCRNG ioctl reseeds the primary_crng from itself, which

Re: [PATCH] random: fix the RNDRESEEDCRNG ioctl

2020-10-26 Thread Eric Biggers
On Tue, Oct 06, 2020 at 08:50:21PM -0700, Eric Biggers wrote: > On Tue, Sep 15, 2020 at 09:19:08PM -0700, Eric Biggers wrote: > > From: Eric Biggers > > > > The RNDRESEEDCRNG ioctl reseeds the primary_crng from itself, which > > doesn't make sense. Reseed it from the input_pool instead. > > > >

Re: [PATCH] random: fix the RNDRESEEDCRNG ioctl

2020-10-06 Thread Jann Horn
On Wed, Sep 16, 2020 at 6:19 AM Eric Biggers wrote: > The RNDRESEEDCRNG ioctl reseeds the primary_crng from itself, which > doesn't make sense. Reseed it from the input_pool instead. Good catch. (And its purpose is to ensure that entropy from random_write() is plumbed all the way through such th

Re: [PATCH] random: fix the RNDRESEEDCRNG ioctl

2020-10-06 Thread Eric Biggers
On Tue, Sep 15, 2020 at 09:19:08PM -0700, Eric Biggers wrote: > From: Eric Biggers > > The RNDRESEEDCRNG ioctl reseeds the primary_crng from itself, which > doesn't make sense. Reseed it from the input_pool instead. > > Fixes: d848e5f8e1eb ("random: add new ioctl RNDRESEEDCRNG") > Cc: sta...@vg

[PATCH] random: fix the RNDRESEEDCRNG ioctl

2020-09-15 Thread Eric Biggers
From: Eric Biggers The RNDRESEEDCRNG ioctl reseeds the primary_crng from itself, which doesn't make sense. Reseed it from the input_pool instead. Fixes: d848e5f8e1eb ("random: add new ioctl RNDRESEEDCRNG") Cc: sta...@vger.kernel.org Signed-off-by: Eric Biggers --- drivers/char/random.c | 2 +-