Re: [PATCH] random: fix folding

2007-06-12 Thread Matt Mackall
On Wed, Jun 13, 2007 at 01:45:21AM -0400, [EMAIL PROTECTED] wrote: > > Folding is done to minimize the theoretical possibility of systematic > > weakness in the particular bits of the SHA1 hash output. The result of > > this bug is that 16 out of 80 bits are un-folded. Without a major new > > vulne

Re: [PATCH] random: fix folding

2007-06-12 Thread linux
> Folding is done to minimize the theoretical possibility of systematic > weakness in the particular bits of the SHA1 hash output. The result of > this bug is that 16 out of 80 bits are un-folded. Without a major new > vulnerability being found in SHA1, this is harmless, but still worth > fixing.

[PATCH] random: fix folding

2007-06-12 Thread Matt Mackall
On Tue, Jun 12, 2007 at 01:05:44AM -0400, [EMAIL PROTECTED] wrote: > I also noticed a glaring BUG in the folding at the end of extract_buf at > drivers/char/random.c:797. That should be: > > /* >* In case the hash function has some recognizable >* output pattern, we fold it