Re: [KBUILD] Re: [BUG] 2.4.0-test11-ac3 breaks raid autodetect (was Re: [BUG] raid5 link error? (was [PATCH] raid5 fix after xor.c cleanup))

2000-11-27 Thread Christoph Hellwig
On Mon, Nov 27, 2000 at 01:18:52PM +1100, Neil Brown wrote: > Thanks for this > > I have looked more deeply, and discovered the error of my ways. > As the Makefiles now stand, all export-objs (OX_OBJS) get linked > before non-export-objs (O_OBJS) in the same directory, independantly > of any

Re: [BUG] 2.4.0-test11-ac3 breaks raid autodetect (was Re: [BUG] raid5 link error? (was [PATCH] raid5 fix after xor.c cleanup))

2000-11-27 Thread Luca Berra
On Mon, Nov 27, 2000 at 01:18:52PM +1100, Neil Brown wrote: > > Sorry to tell you that I just tried linux-2.4.0-test11-ac3 (which has this > > patch) and I couldn't boot because the kernel detects the raid1 devices > > but kicks the shortly after. I had to back out this code. > > Thanks for this.

Re: [BUG] 2.4.0-test11-ac3 breaks raid autodetect (was Re: [BUG] raid5 link error? (was [PATCH] raid5 fix after xor.c cleanup))

2000-11-26 Thread Neil Brown
On Sunday November 26, [EMAIL PROTECTED] wrote: > Neil Brown wrote: > > > > The following patch changes the link order in the Makefile so that xor > > is initiailised before md tries to autostart anything. > > It also takes the theme a bit further and uses module_init/module_exit > > to init and s

[BUG] 2.4.0-test11-ac3 breaks raid autodetect (was Re: [BUG] raid5 link error? (was [PATCH] raid5 fix after xor.c cleanup))

2000-11-25 Thread Friedrich Lobenstock
Neil Brown wrote: > > The following patch changes the link order in the Makefile so that xor > is initiailised before md tries to autostart anything. > It also takes the theme a bit further and uses module_init/module_exit > to init and shutdown the raid personalities. This allows us to remove >

Re: [BUG] raid5 link error? (was [PATCH] raid5 fix after xor.c cleanup)

2000-11-18 Thread Jasper Spaans
On Sat, Nov 18, 2000 at 12:35:36PM +0100, Jasper Spaans wrote: > Hmm, next time I'll need to eat my own dogfood -- this patch doesn't work, > it only compiles. Don't use it. It seems to me the original code was correct, but the linking isn't in the right order and the initcalls are in the wrong

Re: [PATCH] raid5 fix after xor.c cleanup

2000-11-18 Thread Jasper Spaans
On Fri, Nov 17, 2000 at 11:41:44PM +0100, Jasper Spaans wrote: > due to the xor.c cleanup in 2.4.0-test11-pre5+, raid5 compiled into the > kernel fails when booting, because the calibrate_xor_block function > hasn't been called while registering a raid5 volume; this leads to a > panic, as no chec

[PATCH] raid5 fix after xor.c cleanup

2000-11-17 Thread Jasper Spaans
Hi Ingo & lists, due to the xor.c cleanup in 2.4.0-test11-pre5+, raid5 compiled into the kernel fails when booting, because the calibrate_xor_block function hasn't been called while registering a raid5 volume; this leads to a panic, as no checksumming function has been chosen. Here's a tiny patc