Re: [PATCH] race condition with drivers/char/vt.c (bug in vt_ioctl.c)

2005-08-22 Thread Steven Rostedt
On Tue, 2005-08-23 at 08:08 +0800, Antonino A. Daplas wrote: > There's a similar report in Kernel Bugzilla > > http://bugzilla.kernel.org/show_bug.cgi?id=4812 > > I was wondering what's the likelihood of tty->driver_data being NULL in > vt_ioctl but never had the time to do further exploration. Y

Re: [PATCH] race condition with drivers/char/vt.c (bug in vt_ioctl.c)

2005-08-22 Thread Antonino A. Daplas
There's a similar report in Kernel Bugzilla http://bugzilla.kernel.org/show_bug.cgi?id=4812 I was wondering what's the likelihood of tty->driver_data being NULL in vt_ioctl but never had the time to do further exploration. Your patch should fix that bug too. Tony Steven Rostedt wrote: While d

Re: [PATCH] race condition with drivers/char/vt.c (bug in vt_ioctl.c)

2005-08-22 Thread Ingo Molnar
* Steven Rostedt <[EMAIL PROTECTED]> wrote: > I googled a little and found where this may have already happened in > the main line kernel: > > http://seclists.org/lists/linux-kernel/2005/Aug/1603.html > > So here's my proposal: > > Instead of checking for tty->count == 1 in con_open, which

Re: [PATCH] race condition with drivers/char/vt.c (bug in vt_ioctl.c)

2005-08-22 Thread Steven Rostedt
On Mon, 2005-08-22 at 09:13 +0200, Ingo Molnar wrote: > > cool fix. I'm wondering, there's a whole lot of other 'tty->count == 1' > checks in drivers/char/*.c, could some of those be racy too? I checked them out. The main problem is that tty->count == 1 is not reliable in the open function cal

[PATCH] race condition with drivers/char/vt.c (bug in vt_ioctl.c)

2005-08-19 Thread Steven Rostedt
While debugging Ingo's RT patch, I came accross this race condition. The mainline seems to be susceptible to this bug, although it may be 1 in a 1,000,000 to happen. But those are the nastiest races. With debugging information in the RT patch, I was able to reproduce this race several times. Enoug