Re: [PATCH] quota: fix wrong condition in is_quota_modification()

2019-09-16 Thread Chao Yu
On 2019/9/16 16:23, Jan Kara wrote: > On Mon 16-09-19 10:53:08, Chao Yu wrote: >> On 2019/9/12 18:06, Jan Kara wrote: >>> On Wed 11-09-19 17:36:50, Chao Yu wrote: diff --git a/include/linux/quotaops.h b/include/linux/quotaops.h index dc905a4ff8d7..bd30acad3a7f 100644 --- a/include/li

Re: [PATCH] quota: fix wrong condition in is_quota_modification()

2019-09-16 Thread Jan Kara
On Mon 16-09-19 10:53:08, Chao Yu wrote: > On 2019/9/12 18:06, Jan Kara wrote: > > On Wed 11-09-19 17:36:50, Chao Yu wrote: > >> diff --git a/include/linux/quotaops.h b/include/linux/quotaops.h > >> index dc905a4ff8d7..bd30acad3a7f 100644 > >> --- a/include/linux/quotaops.h > >> +++ b/include/linux

Re: [PATCH] quota: fix wrong condition in is_quota_modification()

2019-09-15 Thread Chao Yu
On 2019/9/12 18:06, Jan Kara wrote: > On Wed 11-09-19 17:36:50, Chao Yu wrote: >> Quoted from >> commit 3da40c7b0898 ("ext4: only call ext4_truncate when size <= isize") >> >> " At LSF we decided that if we truncate up from isize we shouldn't trim >> fallocated blocks that were fallocated with KE

Re: [PATCH] quota: fix wrong condition in is_quota_modification()

2019-09-12 Thread Jan Kara
On Wed 11-09-19 17:36:50, Chao Yu wrote: > Quoted from > commit 3da40c7b0898 ("ext4: only call ext4_truncate when size <= isize") > > " At LSF we decided that if we truncate up from isize we shouldn't trim > fallocated blocks that were fallocated with KEEP_SIZE and are past the > new i_size. T

[PATCH] quota: fix wrong condition in is_quota_modification()

2019-09-11 Thread Chao Yu
Quoted from commit 3da40c7b0898 ("ext4: only call ext4_truncate when size <= isize") " At LSF we decided that if we truncate up from isize we shouldn't trim fallocated blocks that were fallocated with KEEP_SIZE and are past the new i_size. This patch fixes ext4 to do this. " And generic/092 o