Re: [PATCH] ptp_pch: include ethernet driver for external functions

2019-10-18 Thread Richard Cochran
On Fri, Oct 18, 2019 at 11:51:28AM +0100, Ben Dooks (Codethink) wrote: > The driver uses a number of functions from the ethernet driver > so include the header to remove the following warnings from > sparse about undeclared functions: > > drivers/ptp/ptp_pch.c:182:5: warning: symbol 'pch_ch_contro

Re: [PATCH] ptp_pch: include ethernet driver for external functions

2019-10-18 Thread Ben Dooks
On 18/10/2019 11:51, Ben Dooks (Codethink) wrote: The driver uses a number of functions from the ethernet driver so include the header to remove the following warnings from sparse about undeclared functions: drivers/ptp/ptp_pch.c:182:5: warning: symbol 'pch_ch_control_read' was not declared. Sh

[PATCH] ptp_pch: include ethernet driver for external functions

2019-10-18 Thread Ben Dooks (Codethink)
The driver uses a number of functions from the ethernet driver so include the header to remove the following warnings from sparse about undeclared functions: drivers/ptp/ptp_pch.c:182:5: warning: symbol 'pch_ch_control_read' was not declared. Should it be static? drivers/ptp/ptp_pch.c:193:6: warn