Re: [PATCH] ptp: make ptp_clock_info const

2017-08-22 Thread David Miller
From: Bhumika Goyal Date: Mon, 21 Aug 2017 23:01:12 +0530 > Make these const as they are only used in a copy operation. > Done using Coccinelle. ... > Signed-off-by: Bhumika Goyal Applied.

Re: [PATCH] ptp: make ptp_clock_info const

2017-08-22 Thread Richard Cochran
On Tue, Aug 22, 2017 at 12:06:23PM +0530, Bhumika Goyal wrote: > By testing I meant that they have been checked by the compiler. I > haven't run the code on a hardware or some test data. Yes, compiling is good enough for this change. Thanks, Richard > > Acked-by: Richard Cochran

Re: [PATCH] ptp: make ptp_clock_info const

2017-08-21 Thread Bhumika Goyal
On Tue, Aug 22, 2017 at 11:57 AM, Richard Cochran wrote: > On Mon, Aug 21, 2017 at 11:01:12PM +0530, Bhumika Goyal wrote: >> File ptp_ixp46x.c is not tested as I could not find any architecture >> to cross compile it. > > No problem. Thanks for test compiling the other drivers. > By testing I me

Re: [PATCH] ptp: make ptp_clock_info const

2017-08-21 Thread Richard Cochran
On Mon, Aug 21, 2017 at 11:01:12PM +0530, Bhumika Goyal wrote: > File ptp_ixp46x.c is not tested as I could not find any architecture > to cross compile it. No problem. Thanks for test compiling the other drivers. Acked-by: Richard Cochran

[PATCH] ptp: make ptp_clock_info const

2017-08-21 Thread Bhumika Goyal
Make these const as they are only used in a copy operation. Done using Coccinelle. @match disable optional_qualifier@ identifier s; @@ static struct ptp_clock_info s = {...}; @ref@ position p; identifier match.s; @@ s@p @good1@ position ref.p; identifier match.s,f,c; expression e; @@ ( e = s@p |