Re: [PATCH] pstore: unconditionally initialize spinlock and flags

2017-02-09 Thread Kees Cook
On Thu, Feb 9, 2017 at 3:04 PM, Brian Norris wrote: > We check to see if a buffer is already sane-looking, and if it's sane, > we don't wipe it. But that's not an excuse to avoid initializing our > spinlocks or setting our flags. Without this, we might see spinlock > debugging messages like this a

[PATCH] pstore: unconditionally initialize spinlock and flags

2017-02-09 Thread Brian Norris
We check to see if a buffer is already sane-looking, and if it's sane, we don't wipe it. But that's not an excuse to avoid initializing our spinlocks or setting our flags. Without this, we might see spinlock debugging messages like this at boot: [0.760836] persistent_ram: found existing buffer