Re: [PATCH] pstore: remove __exit annotation for ramoops_remove

2015-10-22 Thread Geliang Tang
On Thu, Oct 22, 2015 at 04:52:33PM +0200, Arnd Bergmann wrote: > The remove function of a device driver should not be marked > __exit, because that section gets discarded for built-in drivers, > and it is still possible to manually unbind a driver from a > device, which would result in a runtime er

RE: [PATCH] pstore: remove __exit annotation for ramoops_remove

2015-10-22 Thread Luck, Tony
-static int __exit ramoops_remove(struct platform_device *pdev) +static int ramoops_remove(struct platform_device *pdev) Arnd, Thanks. I folded that fix into the commit that made the error and rebased (I don't believe anyone is foolish enough to base work on my "next" branch) -Tony -- To uns

[PATCH] pstore: remove __exit annotation for ramoops_remove

2015-10-22 Thread Arnd Bergmann
The remove function of a device driver should not be marked __exit, because that section gets discarded for built-in drivers, and it is still possible to manually unbind a driver from a device, which would result in a runtime error. The kernel also produces a link error for this when the module is