Re: [PATCH] pstore/ram: fix undefined usage of rounddown_pow_of_two.

2012-10-22 Thread Florian Fainelli
On Friday 19 October 2012 09:03:12 Kees Cook wrote: > On Fri, Oct 19, 2012 at 4:59 AM, Florian Fainelli > wrote: > > From: Maxime Bizon > > > > record_size / console_size / ftrace_size can be 0 (this is how you > > disable the feature), but rounddown_pow_of_two(0) is undefined. This problem > >

Re: [PATCH] pstore/ram: fix undefined usage of rounddown_pow_of_two.

2012-10-19 Thread Kees Cook
On Fri, Oct 19, 2012 at 4:59 AM, Florian Fainelli wrote: > From: Maxime Bizon > > record_size / console_size / ftrace_size can be 0 (this is how you > disable the feature), but rounddown_pow_of_two(0) is undefined. This problem > has been present since commit 1894a253 (ramoops: Move to fs/pstore/

[PATCH] pstore/ram: fix undefined usage of rounddown_pow_of_two.

2012-10-19 Thread Florian Fainelli
From: Maxime Bizon record_size / console_size / ftrace_size can be 0 (this is how you disable the feature), but rounddown_pow_of_two(0) is undefined. This problem has been present since commit 1894a253 (ramoops: Move to fs/pstore/ram.c). Signed-off-by: Maxime Bizon Signed-off-by: Florian Fainel