"__be32 s_addr" ? (was Re: [PATCH] procfs: Fix sparse warnings)

2005-02-16 Thread Alexey Dobriyan
On Wednesday 16 February 2005 10:35, Al Viro wrote: > Most of the mess is in drivers/*, arch/* and (for endianness patches) net/*... Yes, net/*. Many do X.s_addr = htonl(blah). Is this correct? --- a/include/linux/in.h +++ b/include/linux/in.h @@ -51,7 +51,7 @@ enum { /* Internet address. */

Re: [PATCH] procfs: Fix sparse warnings

2005-02-16 Thread Al Viro
On Tue, Feb 15, 2005 at 07:26:18PM +, Al Viro wrote: > Umm... Let's do it that way: I'll get carving the sucker up to relatively > sane point and post it again (-bird, that is). Give me until tomorrow > morning and then feel free to send stuff my way - I'll merge it and feed > upstream when 2

Re: [PATCH] procfs: Fix sparse warnings

2005-02-15 Thread Al Viro
On Tue, Feb 15, 2005 at 03:12:37PM +0200, Alexey Dobriyan wrote: > On Tuesday 15 February 2005 13:59, Al Viro wrote: > > On Tue, Feb 15, 2005 at 02:55:55PM +0200, Alexey Dobriyan wrote: > > > > Let's hold this kind of stuff until 2.6.11, OK? > > > > Al, sitting on more than a megabyte of such

Re: [PATCH] procfs: Fix sparse warnings

2005-02-15 Thread Alexey Dobriyan
On Tuesday 15 February 2005 13:59, Al Viro wrote: > On Tue, Feb 15, 2005 at 02:55:55PM +0200, Alexey Dobriyan wrote: > > Let's hold this kind of stuff until 2.6.11, OK? > > Al, sitting on more than a megabyte of such patches... Could you send diffstat or something? I did "make allyesconfig

Re: [PATCH] procfs: Fix sparse warnings

2005-02-15 Thread Al Viro
On Tue, Feb 15, 2005 at 02:55:55PM +0200, Alexey Dobriyan wrote: [snip] Let's hold this kind of stuff until 2.6.11, OK? Al, sitting on more than a megabyte of such patches... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROT

[PATCH] procfs: Fix sparse warnings

2005-02-15 Thread Alexey Dobriyan
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Index: linux-warnings/fs/proc/base.c === --- linux-warnings/fs/proc/base.c (revision 25) +++ linux-warnings/fs/proc/base.c (revision 29) @@ -689,7 +689,7 @@ .open