Re: [PATCH] proc: fix proc-self-map-files selftest for arm

2018-11-08 Thread Cyrill Gorcunov
On Thu, Nov 08, 2018 at 08:41:46AM -0200, Rafael David Tinoco wrote: > > > > As to me -- yes, I would move zero page testing to a separate memory > > testcase. > > But since Alexey is the former author of the tests better wait for his > > opinion. > > Alexey, > > would you care if we turn those

Re: [PATCH] proc: fix proc-self-map-files selftest for arm

2018-11-08 Thread Rafael David Tinoco
On Mon, Oct 15, 2018 at 2:21 PM, Cyrill Gorcunov wrote: > On Mon, Oct 15, 2018 at 01:55:14PM -0300, Rafael David Tinoco wrote: >> That is what I also had in mind, thus the patch. I just realized we had >> another issue on LKFT (our functional tests tool) for >> proc-self-map-files-001.c. Test 001

Re: [PATCH] proc: fix proc-self-map-files selftest for arm

2018-10-15 Thread Cyrill Gorcunov
On Mon, Oct 15, 2018 at 01:55:14PM -0300, Rafael David Tinoco wrote: > That is what I also had in mind, thus the patch. I just realized we had > another issue on LKFT (our functional tests tool) for > proc-self-map-files-001.c. Test 001 does pretty much the same as 002, but > without the MAP_FIXED

Re: [PATCH] proc: fix proc-self-map-files selftest for arm

2018-10-15 Thread Rafael David Tinoco
On 10/11/18 7:00 PM, Cyrill Gorcunov wrote: On Fri, Oct 12, 2018 at 12:30:06AM +0300, Alexey Dobriyan wrote: On Fri, Oct 12, 2018 at 12:02:56AM +0300, Cyrill Gorcunov wrote: On Thu, Oct 11, 2018 at 11:56:01PM +0300, Alexey Dobriyan wrote: As the comment in the beginning says this test is spec

Re: [PATCH] proc: fix proc-self-map-files selftest for arm

2018-10-11 Thread Cyrill Gorcunov
On Fri, Oct 12, 2018 at 12:30:06AM +0300, Alexey Dobriyan wrote: > On Fri, Oct 12, 2018 at 12:02:56AM +0300, Cyrill Gorcunov wrote: > > On Thu, Oct 11, 2018 at 11:56:01PM +0300, Alexey Dobriyan wrote: > > > > > > As the comment in the beginning says this test is specifically for > > > addresss 0.

Re: [PATCH] proc: fix proc-self-map-files selftest for arm

2018-10-11 Thread Alexey Dobriyan
On Fri, Oct 12, 2018 at 12:02:56AM +0300, Cyrill Gorcunov wrote: > On Thu, Oct 11, 2018 at 11:56:01PM +0300, Alexey Dobriyan wrote: > > > > As the comment in the beginning says this test is specifically for addresss > > 0. > > Maybe it should be ifdeffed with __arm__ then. > > Is there some othe

Re: [PATCH] proc: fix proc-self-map-files selftest for arm

2018-10-11 Thread Cyrill Gorcunov
On Thu, Oct 11, 2018 at 11:56:01PM +0300, Alexey Dobriyan wrote: > > As the comment in the beginning says this test is specifically for addresss 0. > Maybe it should be ifdeffed with __arm__ then. Is there some other reason than allocating non-mergable VMA?

Re: [PATCH] proc: fix proc-self-map-files selftest for arm

2018-10-11 Thread Alexey Dobriyan
On Thu, Oct 11, 2018 at 03:43:59PM -0300, Rafael David Tinoco wrote: > MAP_FIXED is important for this test but, unfortunately, lowest virtual > address for user space mapping on arm is (PAGE_SIZE * 2) and NULL hint > does not seem to guarantee that when MAP_FIXED is given. This patch sets > the vi

Re: [PATCH] proc: fix proc-self-map-files selftest for arm

2018-10-11 Thread Cyrill Gorcunov
On Thu, Oct 11, 2018 at 03:43:59PM -0300, Rafael David Tinoco wrote: > MAP_FIXED is important for this test but, unfortunately, lowest virtual > address for user space mapping on arm is (PAGE_SIZE * 2) and NULL hint > does not seem to guarantee that when MAP_FIXED is given. This patch sets > the vi

[PATCH] proc: fix proc-self-map-files selftest for arm

2018-10-11 Thread Rafael David Tinoco
MAP_FIXED is important for this test but, unfortunately, lowest virtual address for user space mapping on arm is (PAGE_SIZE * 2) and NULL hint does not seem to guarantee that when MAP_FIXED is given. This patch sets the virtual address that will hold the mapping for the test, fixing the issue. Lin