Re: [PATCH] printk: rebalance printk

2015-08-12 Thread Pan Xinhui
On 2015年08月12日 20:31, Peter Hurley wrote: > On 08/11/2015 02:16 PM, Greg Kroah-Hartman wrote: >> On Tue, Aug 11, 2015 at 07:23:01PM +0800, Pan Xinhui wrote: >>> From: Pan Xinhui >>> >>> printk can be called in any context, It's very useful to output debug >>> info. >>> >>> But it might cause ver

Re: [PATCH] printk: rebalance printk

2015-08-12 Thread Peter Hurley
On 08/11/2015 02:16 PM, Greg Kroah-Hartman wrote: > On Tue, Aug 11, 2015 at 07:23:01PM +0800, Pan Xinhui wrote: >> From: Pan Xinhui >> >> printk can be called in any context, It's very useful to output debug >> info. >> >> But it might cause very bad issues on some special cases. For example, >> s

Re: [PATCH] printk: rebalance printk

2015-08-11 Thread Pan Xinhui
On 2015年08月12日 10:04, Greg Kroah-Hartman wrote: > On Wed, Aug 12, 2015 at 09:53:58AM +0800, Pan Xinhui wrote: >> Hi, Greg >> thanks for your reply! >> On 2015年08月12日 02:16, Greg Kroah-Hartman wrote: >>> On Tue, Aug 11, 2015 at 07:23:01PM +0800, Pan Xinhui wrote: From: Pan Xinhui >

Re: [PATCH] printk: rebalance printk

2015-08-11 Thread Greg Kroah-Hartman
On Wed, Aug 12, 2015 at 09:53:58AM +0800, Pan Xinhui wrote: > Hi, Greg > thanks for your reply! > On 2015年08月12日 02:16, Greg Kroah-Hartman wrote: > > On Tue, Aug 11, 2015 at 07:23:01PM +0800, Pan Xinhui wrote: > >> From: Pan Xinhui > >> > >> printk can be called in any context, It's very use

Re: [PATCH] printk: rebalance printk

2015-08-11 Thread Pan Xinhui
Hi, Greg thanks for your reply! On 2015年08月12日 02:16, Greg Kroah-Hartman wrote: > On Tue, Aug 11, 2015 at 07:23:01PM +0800, Pan Xinhui wrote: >> From: Pan Xinhui >> >> printk can be called in any context, It's very useful to output debug >> info. >> >> But it might cause very bad issues on

Re: [PATCH] printk: rebalance printk

2015-08-11 Thread Pan Xinhui
hi, Peter thanks for your reply! On 2015年08月11日 20:00, Peter Hurley wrote: > On 08/11/2015 07:23 AM, Pan Xinhui wrote: >> From: Pan Xinhui >> >> printk can be called in any context, It's very useful to output debug >> info. >> >> But it might cause very bad issues on some special cases. Fo

Re: [PATCH] printk: rebalance printk

2015-08-11 Thread Greg Kroah-Hartman
On Tue, Aug 11, 2015 at 07:23:01PM +0800, Pan Xinhui wrote: > From: Pan Xinhui > > printk can be called in any context, It's very useful to output debug > info. > > But it might cause very bad issues on some special cases. For example, > some driver hit errors, and it dumps many messages like re

Re: [PATCH] printk: rebalance printk

2015-08-11 Thread Peter Hurley
On 08/11/2015 07:23 AM, Pan Xinhui wrote: > From: Pan Xinhui > > printk can be called in any context, It's very useful to output debug > info. > > But it might cause very bad issues on some special cases. For example, > some driver hit errors, and it dumps many messages like reg values, etc. >

Re: [PATCH] printk: rebalance printk

2015-08-11 Thread Pan Xinhui
I think you have already known how to reproduce it. Let me still share the debug patch to hit this printk issue in several seconds. +static int auto_printk(void *data) +{ + int irq = (int)data; + char b[64] = { + [0 ... 61] = 'F', + '\n', + 0,

[PATCH] printk: rebalance printk

2015-08-11 Thread Pan Xinhui
From: Pan Xinhui printk can be called in any context, It's very useful to output debug info. But it might cause very bad issues on some special cases. For example, some driver hit errors, and it dumps many messages like reg values, etc. Sometimes, printk is called when irqs disabled. This is O