Re: [PATCH] printk: fix pr_debug and pr_devel to elide function calls

2015-12-04 Thread Joe Perches
On Fri, 2015-12-04 at 11:38 -0500, Aaron Conole wrote: > Jason Baron writes: > > On 12/03/2015 05:45 PM, Aaron Conole wrote: > > > Currently, pr_debug and pr_devel will not elide function call arguments > > > appearing in calls to no_printk for these macros. This is because all > > > side effects

Re: [PATCH] printk: fix pr_debug and pr_devel to elide function calls

2015-12-04 Thread Aaron Conole
Jason Baron writes: > On 12/03/2015 05:45 PM, Aaron Conole wrote: >> Currently, pr_debug and pr_devel will not elide function call arguments >> appearing in calls to no_printk for these macros. This is because all >> side effects must be honored before proceeding to the 0-value assignment >> in n

Re: [PATCH] printk: fix pr_debug and pr_devel to elide function calls

2015-12-04 Thread Jason Baron
On 12/03/2015 05:45 PM, Aaron Conole wrote: > Currently, pr_debug and pr_devel will not elide function call arguments > appearing in calls to no_printk for these macros. This is because all > side effects must be honored before proceeding to the 0-value assignment > in no_printk. > > The behavior

Re: [PATCH] printk: fix pr_debug and pr_devel to elide function calls

2015-12-03 Thread Joe Perches
On Thu, 2015-12-03 at 17:45 -0500, Aaron Conole wrote: > Currently, pr_debug and pr_devel will not elide function call arguments > appearing in calls to no_printk for these macros. This is because all > side effects must be honored before proceeding to the 0-value assignment > in no_printk. > > Th

[PATCH] printk: fix pr_debug and pr_devel to elide function calls

2015-12-03 Thread Aaron Conole
Currently, pr_debug and pr_devel will not elide function call arguments appearing in calls to no_printk for these macros. This is because all side effects must be honored before proceeding to the 0-value assignment in no_printk. The behavior is contrary to documentation found in the CodingStyle an