Re: [PATCH] printk: Make linux/printk.h self-contained

2020-06-15 Thread Steven Rostedt
On Mon, 15 Jun 2020 21:40:38 +1000 Herbert Xu wrote: > Thanks for investigating. I now realise that this was sent against > my first patch which did have this problem, which was fixed in my > second patch. Sorry for the false alarm. Which is why it is recommended that new patches start their o

Re: [PATCH] printk: Make linux/printk.h self-contained

2020-06-15 Thread Herbert Xu
On Sat, Jun 13, 2020 at 04:29:01PM +0200, Luc Van Oostenryck wrote: > > while there is no such problem with the previous commit. > I think the problem is that: > * ratelimit.h needs raw_spinlock_t > * spinlock_types.h needs lockdep.h > * lockdep.h needs ratelimit.h Thanks for investigating. I now

Re: [PATCH] printk: Make linux/printk.h self-contained

2020-06-13 Thread Luc Van Oostenryck
On Sat, Jun 13, 2020 at 11:09:49PM +1000, Herbert Xu wrote: > On Sat, Jun 13, 2020 at 08:28:34PM +0800, kernel test robot wrote: > > > > Hi Herbert, > > > > I love your patch! Perhaps something to improve: > > > > [auto build test WARNING on linus/master] > > [also build test WARNING on v5.7 nex

Re: [PATCH] printk: Make linux/printk.h self-contained

2020-06-13 Thread Herbert Xu
On Sat, Jun 13, 2020 at 08:28:34PM +0800, kernel test robot wrote: > > Hi Herbert, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on linus/master] > [also build test WARNING on v5.7 next-20200611] > [if your patch is applied to the wrong git tree, please drop u

Re: [PATCH] printk: Make linux/printk.h self-contained

2020-06-13 Thread kernel test robot
Hi Herbert, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.7 next-20200611] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to

Re: [v2 PATCH] printk: Make linux/printk.h self-contained

2020-06-12 Thread Peter Zijlstra
On Fri, Jun 12, 2020 at 03:14:05PM +0200, Petr Mladek wrote: > On Fri 2020-06-12 14:36:35, Herbert Xu wrote: > > As it stands if you include printk.h by itself it will fail to > > compile because it requires definitions from ratelimit.h. However, > > simply including ratelimit.h from printk.h does

Re: [v2 PATCH] printk: Make linux/printk.h self-contained

2020-06-12 Thread Petr Mladek
On Fri 2020-06-12 14:36:35, Herbert Xu wrote: > As it stands if you include printk.h by itself it will fail to > compile because it requires definitions from ratelimit.h. However, > simply including ratelimit.h from printk.h does not work due to > inclusion loops involving sched.h and kernel.h. >

Re: [v2 PATCH] printk: Make linux/printk.h self-contained

2020-06-12 Thread Sergey Senozhatsky
On (20/06/12 14:36), Herbert Xu wrote: > As it stands if you include printk.h by itself it will fail to > compile because it requires definitions from ratelimit.h. However, > simply including ratelimit.h from printk.h does not work due to > inclusion loops involving sched.h and kernel.h. > > This

Re: [v2 PATCH] printk: Make linux/printk.h self-contained

2020-06-12 Thread Andy Shevchenko
On Fri, Jun 12, 2020 at 7:39 AM Herbert Xu wrote: > > As it stands if you include printk.h by itself it will fail to > compile because it requires definitions from ratelimit.h. However, > simply including ratelimit.h from printk.h does not work due to > inclusion loops involving sched.h and kerne

[v2 PATCH] printk: Make linux/printk.h self-contained

2020-06-11 Thread Herbert Xu
As it stands if you include printk.h by itself it will fail to compile because it requires definitions from ratelimit.h. However, simply including ratelimit.h from printk.h does not work due to inclusion loops involving sched.h and kernel.h. This patch solves this by moving bits from ratelimit.h

Re: [PATCH] printk: Make linux/printk.h self-contained

2020-06-11 Thread kernel test robot
Hi Herbert, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on pmladek/for-next linux/master v5.7 next-20200611] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to u

Re: [PATCH] printk: Make linux/printk.h self-contained

2020-06-11 Thread kernel test robot
Hi Herbert, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on pmladek/for-next linux/master v5.7 next-20200611] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also sugg

[PATCH] printk: Make linux/printk.h self-contained

2020-06-11 Thread Herbert Xu
As it stands if you include printk.h it will fail to compile because it requires definitions from ratelimit.h. However, simply including ratelimit.h from printk.h does not work due to inclusion loops involving sched.h and kernel.h. This patch solves this by moving bits from ratelimit.h into a new