Re: [PATCH] printk: Clean up do_syslog() error handling

2017-08-15 Thread Petr Mladek
On Sat 2017-07-29 20:36:36, Nikitas Angelinas wrote: > The error variable in do_syslog() is preemptively set to the error code > before the error condition is checked, and then set to 0 if the error > condition is not encountered. This is not necessary, as it is likely > simpler to return immediate

Re: [PATCH] printk: Clean up do_syslog() error handling

2017-08-01 Thread Sergey Senozhatsky
On (07/29/17 20:36), Nikitas Angelinas wrote: > The error variable in do_syslog() is preemptively set to the error code > before the error condition is checked, and then set to 0 if the error > condition is not encountered. This is not necessary, as it is likely > simpler to return immediately upon

[PATCH] printk: Clean up do_syslog() error handling

2017-07-29 Thread Nikitas Angelinas
The error variable in do_syslog() is preemptively set to the error code before the error condition is checked, and then set to 0 if the error condition is not encountered. This is not necessary, as it is likely simpler to return immediately upon encountering the error condition. A redundant set of