Re: [PATCH] printk/console: Do not suppress information about dropped messages

2019-03-03 Thread Sergey Senozhatsky
On (02/27/19 09:30), Petr Mladek wrote: > Good point! There is a simple fix for this. We could print the warning > also when all messages are proceed and we are about to leave > the for-cycle. I'd prefer to have lost-messages reporting be less of a summary and more of an "error". I think the soone

Re: [PATCH] printk/console: Do not suppress information about dropped messages

2019-02-27 Thread John Ogness
On 2019-02-27, Petr Mladek wrote: >> Imagine a situation where I am expecting a message to come, but don't >> see it because it was dropped. But if no more non-supressed messages >> come, I see neither the expected message nor the dropped message. > > Good point! There is a simple fix for this. We

Re: [PATCH] printk/console: Do not suppress information about dropped messages

2019-02-27 Thread Sergey Senozhatsky
On (02/27/19 09:12), John Ogness wrote: > >> > >> My only objection to this is that the "messages dropped" only comes if a > >> non-supressed message comes. So information about dropped information > >> may never get printed unless some task prints something non-supressed. > >> > >> Imagine a sit

Re: [PATCH] printk/console: Do not suppress information about dropped messages

2019-02-27 Thread Petr Mladek
On Tue 2019-02-26 17:26:57, John Ogness wrote: > On 2019-02-26, Petr Mladek wrote: > > The warning about dropped messages gets lost when the current > > message is above console_loglevel and suppressed. > > Here you are reporting a bug. (More on this below.) Yes. > > The suppressed messages all

Re: [PATCH] printk/console: Do not suppress information about dropped messages

2019-02-27 Thread John Ogness
On 2019-02-27, Sergey Senozhatsky wrote: >>> if (console_seq < log_first_seq) { >>> - len = sprintf(text, >>> - "** %llu printk messages dropped **\n", >>> - log_first_seq - console_seq); >>> +

Re: [PATCH] printk/console: Do not suppress information about dropped messages

2019-02-26 Thread Sergey Senozhatsky
On (02/26/19 17:26), John Ogness wrote: [..] > > if (console_seq < log_first_seq) { > > - len = sprintf(text, > > - "** %llu printk messages dropped **\n", > > - log_first_seq - console_seq); > > +

Re: [PATCH] printk/console: Do not suppress information about dropped messages

2019-02-26 Thread John Ogness
On 2019-02-26, Petr Mladek wrote: > The warning about dropped messages gets lost when the current > message is above console_loglevel and suppressed. Here you are reporting a bug. (More on this below.) > The suppressed messages allow even slow consoles to caught up > with a flood of messages. Th

[PATCH] printk/console: Do not suppress information about dropped messages

2019-02-26 Thread Petr Mladek
The warning about dropped messages gets lost when the current message is above console_loglevel and suppressed. The suppressed messages allow even slow consoles to caught up with a flood of messages. The consoles must not get slowed down by many warnings. Instead, the warning is delayed until the