Re: [PATCH] powerpc: Remove double free

2019-05-18 Thread Michael Ellerman
On Wed, 2019-05-15 at 09:07:50 UTC, "Tobin C. Harding" wrote: > kfree() after kobject_put(). Who ever wrote this was on crack. > > Fixes: 7e8039795a80 ("powerpc/cacheinfo: Fix kobject memleak") > Signed-off-by: Tobin C. Harding Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c

Re: [PATCH] powerpc: Remove double free

2019-05-15 Thread Greg Kroah-Hartman
On Wed, May 15, 2019 at 11:26:03AM +0200, Christophe Leroy wrote: > kobject_put() released index_dir->kobj Yes, but what is that kobject enclosed in? > but who will release 'index' ? The final kobject_put() will do that, see cacheinfo_create_index_dir() for the details. And please do not top-po

Re: [PATCH] powerpc: Remove double free

2019-05-15 Thread Christophe Leroy
kobject_put() released index_dir->kobj but who will release 'index' ? Christophe Le 15/05/2019 à 11:07, Tobin C. Harding a écrit : kfree() after kobject_put(). Who ever wrote this was on crack. Fixes: 7e8039795a80 ("powerpc/cacheinfo: Fix kobject memleak") Signed-off-by: Tobin C. Harding --

[PATCH] powerpc: Remove double free

2019-05-15 Thread Tobin C. Harding
kfree() after kobject_put(). Who ever wrote this was on crack. Fixes: 7e8039795a80 ("powerpc/cacheinfo: Fix kobject memleak") Signed-off-by: Tobin C. Harding --- FTR git log --pretty=format:"%h%x09%an%x09%ad%x09%s" | grep 7e8039795a80 7e8039795a80Tobin C. HardingTue Apr 30 11:09:23