RE: [PATCH] poweroff: fix bug in orderly_poweroff

2012-09-18 Thread Feng Hong
Sent: 2012年9月19日 13:58 To: Feng Hong Cc: a...@linux-foundation.org; gorcu...@openvz.org; keesc...@chromium.org; serge.hal...@canonical.com; linux-kernel@vger.kernel.org Subject: Re: [PATCH] poweroff: fix bug in orderly_poweroff Feng Hong writes: > Hi, Eric > > 1. We are developing on an

Re: [PATCH] poweroff: fix bug in orderly_poweroff

2012-09-18 Thread Eric W. Biederman
Feng Hong writes: > Hi, Eric > > 1. We are developing on an Android phone platform, we use thermal > framework to monitor the temperature, when the temperature above like > 110 degree, thermal framework will use orderly_shutdown to shutdown > phone, however, on Android platform there is no " /sbi

RE: [PATCH] poweroff: fix bug in orderly_poweroff

2012-09-18 Thread Feng Hong
i) Ltd -Original Message- From: Eric W. Biederman [mailto:ebied...@xmission.com] Sent: 2012年9月19日 12:47 To: Feng Hong Cc: a...@linux-foundation.org; gorcu...@openvz.org; keesc...@chromium.org; serge.hal...@canonical.com; linux-kernel@vger.kernel.org Subject: Re: [PATCH] poweroff: fi

Re: [PATCH] poweroff: fix bug in orderly_poweroff

2012-09-18 Thread Eric W. Biederman
hongfeng writes: > orderly_poweroff is trying to poweroff platform by two steps: > step 1: Call userspace application to poweroff > step 2: If userspace poweroff fail, then do a force power off if force param > is set. > > The bug here is, step 1 is always successful with param UMH_NO_WAIT, Thi

Re: [PATCH] poweroff: fix bug in orderly_poweroff

2012-09-18 Thread Kees Cook
On Tue, Sep 18, 2012 at 8:27 PM, hongfeng wrote: > orderly_poweroff is trying to poweroff platform by two steps: > step 1: Call userspace application to poweroff > step 2: If userspace poweroff fail, then do a force power off if force param > is set. > > The bug here is, step 1 is always successf

[PATCH] poweroff: fix bug in orderly_poweroff

2012-09-18 Thread hongfeng
orderly_poweroff is trying to poweroff platform by two steps: step 1: Call userspace application to poweroff step 2: If userspace poweroff fail, then do a force power off if force param is set. The bug here is, step 1 is always successful with param UMH_NO_WAIT, should change to UMH_WAIT_PROC whi