Re: [PATCH] pmem: fix a name collision

2022-06-30 Thread Jane Chu
On 6/30/2022 11:04 AM, Christoph Hellwig wrote: > On Thu, Jun 30, 2022 at 11:51:55AM -0600, Jane Chu wrote: >> -static phys_addr_t to_phys(struct pmem_device *pmem, phys_addr_t offset) >> +static phys_addr_t _to_phys(struct pmem_device *pmem, phys_addr_t offset) > > I'd rather call this pmem_to_ph

Re: [PATCH] pmem: fix a name collision

2022-06-30 Thread Christoph Hellwig
On Thu, Jun 30, 2022 at 11:51:55AM -0600, Jane Chu wrote: > -static phys_addr_t to_phys(struct pmem_device *pmem, phys_addr_t offset) > +static phys_addr_t _to_phys(struct pmem_device *pmem, phys_addr_t offset) I'd rather call this pmem_to_phys as that is a much nicer name.

[PATCH] pmem: fix a name collision

2022-06-30 Thread Jane Chu
Kernel test robot detected name collision when compiled on 'um' architecture. Rename "to_phys()" to "_to_phys()". >> drivers/nvdimm/pmem.c:48:20: error: conflicting types for 'to_phys'; have >> 'phys_addr_t(struct pmem_device *, phys_addr_t)' {aka 'long long unsigned >> int(struct pmem_device