Re: [PATCH] platform: x86: dell-laptop: Add support for keyboard backlight

2015-03-06 Thread Darren Hart
On Thu, Feb 19, 2015 at 11:58:29AM +0100, Gabriele Mazzotta wrote: > This patch adds the support for the configuration of the keyboard > backlight on supported Dell laptops. > > With this patch it is possible to set: > * keyboard backlight level > * timeout after which the backlight will be automa

Re: [PATCH] platform: x86: dell-laptop: Add support for keyboard backlight

2015-02-25 Thread Darren Hart
On Sun, Feb 22, 2015 at 12:04:23PM +0100, Pali Rohár wrote: > On Thursday 19 February 2015 11:58:29 Gabriele Mazzotta wrote: > > This patch adds the support for the configuration of the > > keyboard backlight on supported Dell laptops. > > > > With this patch it is possible to set: > > * keyboard

Re: [PATCH] platform: x86: dell-laptop: Add support for keyboard backlight

2015-02-22 Thread Pali Rohár
On Thursday 19 February 2015 11:58:29 Gabriele Mazzotta wrote: > This patch adds the support for the configuration of the > keyboard backlight on supported Dell laptops. > > With this patch it is possible to set: > * keyboard backlight level > * timeout after which the backlight will be automatica

[PATCH] platform: x86: dell-laptop: Add support for keyboard backlight

2015-02-19 Thread Gabriele Mazzotta
This patch adds the support for the configuration of the keyboard backlight on supported Dell laptops. With this patch it is possible to set: * keyboard backlight level * timeout after which the backlight will be automatically turned off * input activity triggers (keyboard, touchpad, mouse) that e

Re: [PATCH] platform: x86: dell-laptop: Add support for keyboard backlight

2014-11-23 Thread Pali Rohár
On Friday 21 November 2014 23:09:40 Darren Hart wrote: > On Sat, Nov 22, 2014 at 07:46:25PM +0100, Pali Rohár wrote: > > > > 0 Completed successfully > > > > -1 Completed with error > > > > -2 Function not supported > > > > > > > > So we can return something other too (not always > > > > -EINV

Re: [PATCH] platform: x86: dell-laptop: Add support for keyboard backlight

2014-11-22 Thread Darren Hart
On Sat, Nov 22, 2014 at 07:46:25PM +0100, Pali Rohár wrote: > > > 0 Completed successfully > > > -1 Completed with error > > > -2 Function not supported > > > > > > So we can return something other too (not always -EINVAL). > > > Do you have any idea which errno should we return for -1 > > >

Re: [PATCH] platform: x86: dell-laptop: Add support for keyboard backlight

2014-11-22 Thread Pali Rohár
On Friday 21 November 2014 21:39:30 Darren Hart wrote: > On Wed, Nov 19, 2014 at 09:41:20PM +0100, Pali Rohár wrote: > > Hello, > > Hi Pali, > > > I removed other lines so mail is not too long. > > > On Wednesday 19 November 2014 19:34:16 Darren Hart wrote: > ... > > > > > +} > > > > + > > > >

Re: [PATCH] platform: x86: dell-laptop: Add support for keyboard backlight

2014-11-22 Thread Darren Hart
On Wed, Nov 19, 2014 at 09:41:20PM +0100, Pali Rohár wrote: > Hello, Hi Pali, > > I removed other lines so mail is not too long. > > On Wednesday 19 November 2014 19:34:16 Darren Hart wrote: ... > > > +} > > > + > > > +static unsigned int kbd_get_max_level(void) > > > +{ > > > + if (kbd_info.le

Re: [PATCH] platform: x86: dell-laptop: Add support for keyboard backlight

2014-11-19 Thread Pali Rohár
Hello, I removed other lines so mail is not too long. On Wednesday 19 November 2014 19:34:16 Darren Hart wrote: > > +static int kbd_get_info(struct kbd_info *info) > > +{ > > + u8 units; > > + int ret; > > + > > + get_buffer(); > > + > > + buffer->input[0] = 0x0; > > + dell_send_request

Re: [PATCH] platform: x86: dell-laptop: Add support for keyboard backlight

2014-11-19 Thread Darren Hart
On Wed, Nov 19, 2014 at 08:51:28PM +0100, Pali Rohár wrote: > On Wednesday 19 November 2014 20:23:36 Matthew Garrett wrote: > > On Wed, Nov 19, 2014 at 10:34:16AM -0800, Darren Hart wrote: > > > I'm somewhat concerned that this patch doubles the size of > > > this driver. When we're adding this muc

Re: [PATCH] platform: x86: dell-laptop: Add support for keyboard backlight

2014-11-19 Thread Pali Rohár
On Wednesday 19 November 2014 20:23:36 Matthew Garrett wrote: > On Wed, Nov 19, 2014 at 10:34:16AM -0800, Darren Hart wrote: > > I'm somewhat concerned that this patch doubles the size of > > this driver. When we're adding this much code, I have to > > ask - does it make sense to grow this driver r

Re: [PATCH] platform: x86: dell-laptop: Add support for keyboard backlight

2014-11-19 Thread Matthew Garrett
On Wed, Nov 19, 2014 at 10:34:16AM -0800, Darren Hart wrote: > I'm somewhat concerned that this patch doubles the size of this driver. When > we're adding this much code, I have to ask - does it make sense to grow this > driver rather than create a new one? There'd be a fair amount of code duplic

Re: [PATCH] platform: x86: dell-laptop: Add support for keyboard backlight

2014-11-19 Thread Darren Hart
On Fri, Nov 14, 2014 at 01:23:33PM +0100, Pali Rohár wrote: > This patch adds support for configuring keyboard backlight settings on > supported > Dell laptops. It exports kernel leds interface and uses Dell SMBIOS tokens or > keyboard class interface. > > With this patch it is possible to set: >

[PATCH] platform: x86: dell-laptop: Add support for keyboard backlight

2014-11-14 Thread Pali Rohár
This patch adds support for configuring keyboard backlight settings on supported Dell laptops. It exports kernel leds interface and uses Dell SMBIOS tokens or keyboard class interface. With this patch it is possible to set: * keyboard backlight level * timeout after which will be backlight automat