Re: [PATCH] platform/x86: thinkpad_acpi: suppress warning about palm detection

2018-02-05 Thread Matthew Thode
On 18-02-05 15:08:25, Andy Shevchenko wrote: > On Mon, Feb 5, 2018 at 1:34 PM, Henrique de Moraes Holschuh > wrote: > >> > I'm fine with a signed-off-by or tested-by or suggested-by. There is a > >> > spelling mistake though, 'hoveres' should be hovers. > >> > >> Is there anything else I can do h

Re: [PATCH] platform/x86: thinkpad_acpi: suppress warning about palm detection

2018-02-05 Thread Andy Shevchenko
On Mon, Feb 5, 2018 at 1:34 PM, Henrique de Moraes Holschuh wrote: >> > I'm fine with a signed-off-by or tested-by or suggested-by. There is a >> > spelling mistake though, 'hoveres' should be hovers. >> >> Is there anything else I can do here? I'm not sure any of us have the >> ability to find

Re: [PATCH] platform/x86: thinkpad_acpi: suppress warning about palm detection

2018-02-05 Thread Henrique de Moraes Holschuh
> > I'm fine with a signed-off-by or tested-by or suggested-by. There is a > > spelling mistake though, 'hoveres' should be hovers. > > Is there anything else I can do here? I'm not sure any of us have the > ability to find out what lenovo actualy wants this for. I have already acked the patch,

Re: [PATCH] platform/x86: thinkpad_acpi: suppress warning about palm detection

2018-02-04 Thread Matthew Thode
On 18-01-13 00:33:09, Matthew Thode wrote: > On 18-01-12 15:07:12, David Herrmann wrote: > > Hi Andy > > > > On Fri, Jan 12, 2018 at 2:50 PM, Andy Shevchenko > > wrote: > > > On Fri, Jan 12, 2018 at 1:04 PM, David Herrmann > > > wrote: > > >> Cc: Matthew Thode > > > > > > Shouldn't be Suggeste

Re: [PATCH] platform/x86: thinkpad_acpi: suppress warning about palm detection

2018-02-04 Thread Matthew Thode
On 18-01-13 00:33:09, Matthew Thode wrote: > On 18-01-12 15:07:12, David Herrmann wrote: > > Hi Andy > > > > On Fri, Jan 12, 2018 at 2:50 PM, Andy Shevchenko > > wrote: > > > On Fri, Jan 12, 2018 at 1:04 PM, David Herrmann > > > wrote: > > >> Cc: Matthew Thode > > > > > > Shouldn't be Suggeste

Re: [PATCH] platform/x86: thinkpad_acpi: suppress warning about palm detection

2018-01-12 Thread Matthew Thode
On 18-01-12 15:07:12, David Herrmann wrote: > Hi Andy > > On Fri, Jan 12, 2018 at 2:50 PM, Andy Shevchenko > wrote: > > On Fri, Jan 12, 2018 at 1:04 PM, David Herrmann > > wrote: > >> Cc: Matthew Thode > > > > Shouldn't be Suggested-by or even Signed-off-by? > > The patch is different (Matthe

Re: [PATCH] platform/x86: thinkpad_acpi: suppress warning about palm detection

2018-01-12 Thread David Herrmann
Hi Andy On Fri, Jan 12, 2018 at 2:50 PM, Andy Shevchenko wrote: > On Fri, Jan 12, 2018 at 1:04 PM, David Herrmann wrote: >> This patch prevents the thinkpad_acpi driver from warning about 2 event >> codes returned for keyboard palm-detection. No behavioral changes, >> other than suppressing the

Re: [PATCH] platform/x86: thinkpad_acpi: suppress warning about palm detection

2018-01-12 Thread Andy Shevchenko
On Fri, Jan 12, 2018 at 1:04 PM, David Herrmann wrote: > This patch prevents the thinkpad_acpi driver from warning about 2 event > codes returned for keyboard palm-detection. No behavioral changes, > other than suppressing the warning in the kernel log. The events are > still forwarded via acpi-ne

Re: [PATCH] platform/x86: thinkpad_acpi: suppress warning about palm detection

2018-01-12 Thread Henrique de Moraes Holschuh
On Fri, 12 Jan 2018, David Herrmann wrote: > This patch prevents the thinkpad_acpi driver from warning about 2 event > codes returned for keyboard palm-detection. No behavioral changes, > other than suppressing the warning in the kernel log. The events are > still forwarded via acpi-netlink channel

[PATCH] platform/x86: thinkpad_acpi: suppress warning about palm detection

2018-01-12 Thread David Herrmann
This patch prevents the thinkpad_acpi driver from warning about 2 event codes returned for keyboard palm-detection. No behavioral changes, other than suppressing the warning in the kernel log. The events are still forwarded via acpi-netlink channels. We could, optionally, decide to forward the eve