Re: [PATCH] platform/x86: fujitsu-laptop: Fix radio LED detection

2017-10-31 Thread Harvey
> I agree as well. The erroneous log messages will only be generated when > any rfkill device in the system is enabled or disabled, so IMHO this is > mostly a nuisance thus can be handled when convenient. FWIW: They are generated several times during every startup of the machine: sudo journalctl

Re: [PATCH] platform/x86: fujitsu-laptop: Fix radio LED detection

2017-10-30 Thread Michał Kępień
> > Do you consider this an important fix? We are at -rc7 now, I'm not > > sure it's so critical. Tell me if you consider otherwise. > > I agree - from my perspective I wouldn't have thought it so critical as to > push it out this late in the development cycle. It's not a regression as > such and

Re: [PATCH] platform/x86: fujitsu-laptop: Fix radio LED detection

2017-10-30 Thread Andy Shevchenko
On Mon, Oct 30, 2017 at 2:12 PM, Jonathan Woithe wrote: > On Mon, Oct 30, 2017 at 01:21:50PM +0200, Andy Shevchenko wrote: >> On Sun, Oct 29, 2017 at 11:28 PM, Micha?? K??pie?? wrote: >> >> On Wed, Oct 25, 2017 at 7:29 AM, Micha?? K??pie?? >> >> wrote: >> >> > Radio LED detection method impleme

Re: [PATCH] platform/x86: fujitsu-laptop: Fix radio LED detection

2017-10-30 Thread Jonathan Woithe
On Mon, Oct 30, 2017 at 01:21:50PM +0200, Andy Shevchenko wrote: > On Sun, Oct 29, 2017 at 11:28 PM, Micha?? K??pie?? wrote: > >> On Wed, Oct 25, 2017 at 7:29 AM, Micha?? K??pie?? > >> wrote: > >> > Radio LED detection method implemented in commit 4f62568c1fcf > >> > ("fujitsu-laptop: Support ra

Re: [PATCH] platform/x86: fujitsu-laptop: Fix radio LED detection

2017-10-30 Thread Andy Shevchenko
On Sun, Oct 29, 2017 at 11:28 PM, Michał Kępień wrote: >> On Wed, Oct 25, 2017 at 7:29 AM, Michał Kępień wrote: >> > Radio LED detection method implemented in commit 4f62568c1fcf >> > ("fujitsu-laptop: Support radio LED") turned out to be incorrect as it >> > causes a radio LED to be erroneously

Re: [PATCH] platform/x86: fujitsu-laptop: Fix radio LED detection

2017-10-29 Thread Michał Kępień
> On Wed, Oct 25, 2017 at 7:29 AM, Michał Kępień wrote: > > Radio LED detection method implemented in commit 4f62568c1fcf > > ("fujitsu-laptop: Support radio LED") turned out to be incorrect as it > > causes a radio LED to be erroneously detected on a Fujitsu Lifebook E751 > > which has a slide sw

Re: [PATCH] platform/x86: fujitsu-laptop: Fix radio LED detection

2017-10-27 Thread Andy Shevchenko
On Wed, Oct 25, 2017 at 7:29 AM, Michał Kępień wrote: > Radio LED detection method implemented in commit 4f62568c1fcf > ("fujitsu-laptop: Support radio LED") turned out to be incorrect as it > causes a radio LED to be erroneously detected on a Fujitsu Lifebook E751 > which has a slide switch (and

Re: [PATCH] platform/x86: fujitsu-laptop: Fix radio LED detection

2017-10-25 Thread Harvey
Am 25.10.2017 um 08:33 schrieb Jonathan Woithe: > On Wed, Oct 25, 2017 at 06:29:46AM +0200, Micha?? K??pie?? wrote: >> Radio LED detection method implemented in commit 4f62568c1fcf >> ("fujitsu-laptop: Support radio LED") turned out to be incorrect as it >> causes a radio LED to be erroneously dete

Re: [PATCH] platform/x86: fujitsu-laptop: Fix radio LED detection

2017-10-24 Thread Jonathan Woithe
On Wed, Oct 25, 2017 at 06:29:46AM +0200, Micha?? K??pie?? wrote: > Radio LED detection method implemented in commit 4f62568c1fcf > ("fujitsu-laptop: Support radio LED") turned out to be incorrect as it > causes a radio LED to be erroneously detected on a Fujitsu Lifebook E751 > which has a slide s

[PATCH] platform/x86: fujitsu-laptop: Fix radio LED detection

2017-10-24 Thread Michał Kępień
Radio LED detection method implemented in commit 4f62568c1fcf ("fujitsu-laptop: Support radio LED") turned out to be incorrect as it causes a radio LED to be erroneously detected on a Fujitsu Lifebook E751 which has a slide switch (and thus no radio LED). Use bit 17 of flags_supported (the value r