Re: [PATCH] platform/x86: dell-laptop: Guard SMBIOS calls with a mutex

2018-01-31 Thread Darren Hart
On Tue, Jan 30, 2018 at 05:39:58PM +0200, Andy Shevchenko wrote: > On Tue, Jan 30, 2018 at 5:35 PM, wrote: > > >> > dell_set_arguments(0x2, 0, 0, 0); > >> > ret = dell_send_request(CLASS_INFO, SELECT_RFKILL); > >> > >> Hi! I'm looking at this code, and do we need shared global buffer wit

Re: [PATCH] platform/x86: dell-laptop: Guard SMBIOS calls with a mutex

2018-01-30 Thread Andy Shevchenko
On Tue, Jan 30, 2018 at 5:35 PM, wrote: >> > dell_set_arguments(0x2, 0, 0, 0); >> > ret = dell_send_request(CLASS_INFO, SELECT_RFKILL); >> >> Hi! I'm looking at this code, and do we need shared global buffer with >> mutex protection at all? Is not buffer allocated on stack enough? > > Oh

RE: [PATCH] platform/x86: dell-laptop: Guard SMBIOS calls with a mutex

2018-01-30 Thread Mario.Limonciello
KML ; platform-driver-...@vger.kernel.org > Subject: Re: [PATCH] platform/x86: dell-laptop: Guard SMBIOS calls with a > mutex > > On Monday 29 January 2018 17:15:56 Mario Limonciello wrote: > > Suggested-by: Pali Rohar > > Signed-off-by: Mario Limonciello > &g

Re: [PATCH] platform/x86: dell-laptop: Guard SMBIOS calls with a mutex

2018-01-30 Thread Pali Rohár
On Monday 29 January 2018 17:15:56 Mario Limonciello wrote: > Suggested-by: Pali Rohar > Signed-off-by: Mario Limonciello > --- > drivers/platform/x86/dell-laptop.c | 67 > ++ > 1 file changed, 53 insertions(+), 14 deletions(-) > > diff --git a/drivers/platf

[PATCH] platform/x86: dell-laptop: Guard SMBIOS calls with a mutex

2018-01-29 Thread Mario Limonciello
Suggested-by: Pali Rohar Signed-off-by: Mario Limonciello --- drivers/platform/x86/dell-laptop.c | 67 ++ 1 file changed, 53 insertions(+), 14 deletions(-) diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c index fc2dfc8..f8