Re: [PATCH] platform/x86: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-05 Thread Andy Shevchenko
On Wed, Dec 5, 2018 at 10:56 AM Rajneesh Bhardwaj wrote: > Hi Andy, i was thinking of having it split into two patches as it touches > two unrelated files. What is your opinion? If it is the case, I agree with you. Since patch didn't applied clearly I even had no chance to look at it closer. >

Re: [PATCH] platform/x86: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-05 Thread Rajneesh Bhardwaj
On Wed, Dec 05, 2018 at 10:42:21AM +0200, Andy Shevchenko wrote: > On Wed, Dec 5, 2018 at 3:47 AM Frank Lee wrote: > > On Wed, Dec 5, 2018 at 1:39 AM Andy Shevchenko > > wrote: > > > On Tue, Dec 4, 2018 at 6:58 PM Frank Lee wrote: > > > > > $ git remote set-branches --add origin for-next > > >

Re: [PATCH] platform/x86: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-05 Thread Andy Shevchenko
On Wed, Dec 5, 2018 at 3:47 AM Frank Lee wrote: > On Wed, Dec 5, 2018 at 1:39 AM Andy Shevchenko > wrote: > > On Tue, Dec 4, 2018 at 6:58 PM Frank Lee wrote: > > > $ git remote set-branches --add origin for-next > > > $ git br -vv > > > * for-next 651022382c7f [origin/for-next] Linux 4.20-rc1 >

Re: [PATCH] platform/x86: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-04 Thread Frank Lee
On Wed, Dec 5, 2018 at 1:39 AM Andy Shevchenko wrote: > > On Tue, Dec 4, 2018 at 6:58 PM Frank Lee wrote: > > > $ git br -r > > origin/HEAD -> origin/master > > origin/fixes > > origin/for-next > > origin/master > > origin/review-andy > > $ git remote set-branches --add origin for-next

Re: [PATCH] platform/x86: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-04 Thread Andy Shevchenko
On Tue, Dec 4, 2018 at 6:58 PM Frank Lee wrote: > $ git br -r > origin/HEAD -> origin/master > origin/fixes > origin/for-next > origin/master > origin/review-andy > $ git remote set-branches --add origin for-next > $ git br -vv > * for-next 651022382c7f [origin/for-next] Linux 4.20-rc1

Re: [PATCH] platform/x86: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-04 Thread Frank Lee
On Wed, Dec 5, 2018 at 12:18 AM Andy Shevchenko wrote: > > On Tue, Dec 4, 2018 at 5:30 PM Frank Lee wrote: > > On Tue, Dec 4, 2018 at 8:40 PM Andy Shevchenko > > wrote: > > > On Tue, Dec 4, 2018 at 5:59 AM Frank Lee wrote: > > > > On Tue, Dec 4, 2018 at 3:09 AM Andy Shevchenko > > > > wrote: >

Re: [PATCH] platform/x86: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-04 Thread Andy Shevchenko
On Tue, Dec 4, 2018 at 5:30 PM Frank Lee wrote: > On Tue, Dec 4, 2018 at 8:40 PM Andy Shevchenko > wrote: > > On Tue, Dec 4, 2018 at 5:59 AM Frank Lee wrote: > > > On Tue, Dec 4, 2018 at 3:09 AM Andy Shevchenko > > > wrote: > > > > On Sat, Dec 1, 2018 at 5:52 PM Yangtao Li wrote: > > > > > Use

Re: [PATCH] platform/x86: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-04 Thread Frank Lee
On Tue, Dec 4, 2018 at 8:40 PM Andy Shevchenko wrote: > > On Tue, Dec 4, 2018 at 5:59 AM Frank Lee wrote: > > > > On Tue, Dec 4, 2018 at 3:09 AM Andy Shevchenko > > wrote: > > > > > > On Sat, Dec 1, 2018 at 5:52 PM Yangtao Li wrote: > > > > > > > > Use DEFINE_SHOW_ATTRIBUTE macro to simplify th

Re: [PATCH] platform/x86: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-04 Thread Andy Shevchenko
On Tue, Dec 4, 2018 at 5:59 AM Frank Lee wrote: > > On Tue, Dec 4, 2018 at 3:09 AM Andy Shevchenko > wrote: > > > > On Sat, Dec 1, 2018 at 5:52 PM Yangtao Li wrote: > > > > > > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > I like your patch, but... > > By some reason it's not appli

Re: [PATCH] platform/x86: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-03 Thread Frank Lee
On Tue, Dec 4, 2018 at 3:09 AM Andy Shevchenko wrote: > > On Sat, Dec 1, 2018 at 5:52 PM Yangtao Li wrote: > > > > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > By some reason it's not applicable. > Please, rebase on top of our for-next branch, thanks! For what reason? I thought that

Re: [PATCH] platform/x86: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-03 Thread Andy Shevchenko
On Sat, Dec 1, 2018 at 5:52 PM Yangtao Li wrote: > > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. By some reason it's not applicable. Please, rebase on top of our for-next branch, thanks! > > Signed-off-by: Yangtao Li > --- > drivers/platform/x86/intel_pmc_core.c | 46

[PATCH] platform/x86: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-01 Thread Yangtao Li
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Yangtao Li --- drivers/platform/x86/intel_pmc_core.c | 46 --- .../platform/x86/intel_telemetry_debugfs.c| 42 +++-- 2 files changed, 14 insertions(+), 74 deletions(-) diff --git a/drive