Re: [PATCH] platform/x86: asus-wmi: fix cpufv sysfs file permission

2017-04-25 Thread Andy Shevchenko
On Mon, Apr 24, 2017 at 6:31 PM, Jérémy Lefaure wrote: > On Mon, 24 Apr 2017 12:14:14 +0300 > Andy Shevchenko wrote: > >> On Sat, Apr 22, 2017 at 5:19 AM, Jérémy Lefaure >> wrote: >> > The cpufv sysfs file is defined as readable by anyone even if the >> > attribute does not have a show function.

Re: [PATCH] platform/x86: asus-wmi: fix cpufv sysfs file permission

2017-04-24 Thread Jérémy Lefaure
On Mon, 24 Apr 2017 12:14:14 +0300 Andy Shevchenko wrote: > On Sat, Apr 22, 2017 at 5:19 AM, Jérémy Lefaure > wrote: > > The cpufv sysfs file is defined as readable by anyone even if the > > attribute does not have a show function. The result of every read is an > > IO error. This file should be

Re: [PATCH] platform/x86: asus-wmi: fix cpufv sysfs file permission

2017-04-24 Thread Andy Shevchenko
On Sat, Apr 22, 2017 at 5:19 AM, Jérémy Lefaure wrote: > The cpufv sysfs file is defined as readable by anyone even if the > attribute does not have a show function. The result of every read is an > IO error. This file should be write only. Per se patch looks good to me, though would be better to

[PATCH] platform/x86: asus-wmi: fix cpufv sysfs file permission

2017-04-21 Thread Jérémy Lefaure
The cpufv sysfs file is defined as readable by anyone even if the attribute does not have a show function. The result of every read is an IO error. This file should be write only. Signed-off-by: Jérémy Lefaure --- drivers/platform/x86/asus-wmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 delet