Re: [PATCH] pipe: read/write_iter() handler should check for IOCB_NOWAIT

2020-04-30 Thread Jens Axboe
On 4/30/20 10:14 PM, Jens Axboe wrote: > On 4/30/20 9:58 PM, Al Viro wrote: >> On Thu, Apr 30, 2020 at 10:24:46AM -0600, Jens Axboe wrote: >>> Pipe read/write only checks for the file O_NONBLOCK flag, but we should >>> also check for IOCB_NOWAIT for whether or not we should handle this read >>> or

Re: [PATCH] pipe: read/write_iter() handler should check for IOCB_NOWAIT

2020-04-30 Thread Jens Axboe
On 4/30/20 9:58 PM, Al Viro wrote: > On Thu, Apr 30, 2020 at 10:24:46AM -0600, Jens Axboe wrote: >> Pipe read/write only checks for the file O_NONBLOCK flag, but we should >> also check for IOCB_NOWAIT for whether or not we should handle this read >> or write in a non-blocking fashion. If we don't,

Re: [PATCH] pipe: read/write_iter() handler should check for IOCB_NOWAIT

2020-04-30 Thread Al Viro
On Thu, Apr 30, 2020 at 10:24:46AM -0600, Jens Axboe wrote: > Pipe read/write only checks for the file O_NONBLOCK flag, but we should > also check for IOCB_NOWAIT for whether or not we should handle this read > or write in a non-blocking fashion. If we don't, then we will block on > data or space f

Re: [PATCH] pipe: read/write_iter() handler should check for IOCB_NOWAIT

2020-04-30 Thread Jens Axboe
On 4/30/20 1:51 PM, Jens Axboe wrote: > On 4/30/20 12:47 PM, Jens Axboe wrote: >> On 4/30/20 11:58 AM, Matthew Wilcox wrote: >>> On Thu, Apr 30, 2020 at 10:24:46AM -0600, Jens Axboe wrote: Pipe read/write only checks for the file O_NONBLOCK flag, but we should also check for IOCB_NOWAIT f

Re: [PATCH] pipe: read/write_iter() handler should check for IOCB_NOWAIT

2020-04-30 Thread Jens Axboe
On 4/30/20 12:47 PM, Jens Axboe wrote: > On 4/30/20 11:58 AM, Matthew Wilcox wrote: >> On Thu, Apr 30, 2020 at 10:24:46AM -0600, Jens Axboe wrote: >>> Pipe read/write only checks for the file O_NONBLOCK flag, but we should >>> also check for IOCB_NOWAIT for whether or not we should handle this read

Re: [PATCH] pipe: read/write_iter() handler should check for IOCB_NOWAIT

2020-04-30 Thread Jens Axboe
On 4/30/20 11:58 AM, Matthew Wilcox wrote: > On Thu, Apr 30, 2020 at 10:24:46AM -0600, Jens Axboe wrote: >> Pipe read/write only checks for the file O_NONBLOCK flag, but we should >> also check for IOCB_NOWAIT for whether or not we should handle this read >> or write in a non-blocking fashion. If w

Re: [PATCH] pipe: read/write_iter() handler should check for IOCB_NOWAIT

2020-04-30 Thread Matthew Wilcox
On Thu, Apr 30, 2020 at 10:24:46AM -0600, Jens Axboe wrote: > Pipe read/write only checks for the file O_NONBLOCK flag, but we should > also check for IOCB_NOWAIT for whether or not we should handle this read > or write in a non-blocking fashion. If we don't, then we will block on > data or space f

[PATCH] pipe: read/write_iter() handler should check for IOCB_NOWAIT

2020-04-30 Thread Jens Axboe
Pipe read/write only checks for the file O_NONBLOCK flag, but we should also check for IOCB_NOWAIT for whether or not we should handle this read or write in a non-blocking fashion. If we don't, then we will block on data or space for iocbs that explicitly asked for non-blocking operation. This mess