Re: [PATCH] pinctrl: zynq: change error code for pinctrl_register failure

2015-06-01 Thread Linus Walleij
On Tue, May 26, 2015 at 8:37 PM, Sören Brinkmann wrote: > On Tue, 2015-05-26 at 10:12AM +0200, Arnd Bergmann wrote: >> Could we add a pinctrl_register_reason() variant that returns a meaningful >> error code as ERR_PTR? > > I agree with Arnd. As long as we don't get a precise error code we can >

Re: [PATCH] pinctrl: zynq: change error code for pinctrl_register failure

2015-05-26 Thread Masahiro Yamada
Hi Sören, 2015-05-27 3:37 GMT+09:00 Sören Brinkmann : > On Tue, 2015-05-26 at 10:12AM +0200, Arnd Bergmann wrote: >> On Tuesday 26 May 2015 13:18:29 Masahiro Yamada wrote: >> > diff --git a/drivers/pinctrl/pinctrl-zynq.c >> > b/drivers/pinctrl/pinctrl-zynq.c >> > index 04748a4..0ff653c 100644 >>

Re: [PATCH] pinctrl: zynq: change error code for pinctrl_register failure

2015-05-26 Thread Sören Brinkmann
On Tue, 2015-05-26 at 10:12AM +0200, Arnd Bergmann wrote: > On Tuesday 26 May 2015 13:18:29 Masahiro Yamada wrote: > > diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c > > index 04748a4..0ff653c 100644 > > --- a/drivers/pinctrl/pinctrl-zynq.c > > +++ b/drivers/pinctrl/pi

Re: [PATCH] pinctrl: zynq: change error code for pinctrl_register failure

2015-05-26 Thread Masahiro Yamada
Hi Arnd, 2015-05-26 17:12 GMT+09:00 Arnd Bergmann : > On Tuesday 26 May 2015 13:18:29 Masahiro Yamada wrote: >> diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c >> index 04748a4..0ff653c 100644 >> --- a/drivers/pinctrl/pinctrl-zynq.c >> +++ b/drivers/pinctrl/pinctrl-zy

Re: [PATCH] pinctrl: zynq: change error code for pinctrl_register failure

2015-05-26 Thread Arnd Bergmann
On Tuesday 26 May 2015 13:18:29 Masahiro Yamada wrote: > diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c > index 04748a4..0ff653c 100644 > --- a/drivers/pinctrl/pinctrl-zynq.c > +++ b/drivers/pinctrl/pinctrl-zynq.c > @@ -1141,7 +1141,7 @@ static int zynq_pinctrl_probe(s

[PATCH] pinctrl: zynq: change error code for pinctrl_register failure

2015-05-25 Thread Masahiro Yamada
pinctrl_register() could fail for memory unrelated errors. Returning -EINVAL (or -ENODEV) seems more suitable for here. At least, the other pinctrl drivers do so. Signed-off-by: Masahiro Yamada --- drivers/pinctrl/pinctrl-zynq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git