Re: [PATCH] pinctrl: tegra: use signed bitfields for optional fields

2015-03-16 Thread Stefan Agner
On 2015-03-15 01:05, Stefan Agner wrote: > Optional fields are set to -1 by various preprocessor macros. Make > sure the struct fields can actually store them. > > Signed-off-by: Stefan Agner > --- > This lead to a lot of warnings when compiling the Tegra pinctrl drivers > using LLVM/clang: > >

Re: [PATCH] pinctrl: tegra: use signed bitfields for optional fields

2015-03-16 Thread Stefan Agner
On 2015-03-16 17:59, Stephen Warren wrote: > On 03/14/2015 06:05 PM, Stefan Agner wrote: >> Optional fields are set to -1 by various preprocessor macros. Make >> sure the struct fields can actually store them. > >> diff --git a/drivers/pinctrl/pinctrl-tegra.h >> b/drivers/pinctrl/pinctrl-tegra.h

Re: [PATCH] pinctrl: tegra: use signed bitfields for optional fields

2015-03-16 Thread Stephen Warren
On 03/14/2015 06:05 PM, Stefan Agner wrote: Optional fields are set to -1 by various preprocessor macros. Make sure the struct fields can actually store them. diff --git a/drivers/pinctrl/pinctrl-tegra.h b/drivers/pinctrl/pinctrl-tegra.h - u32 mux_bit:6; - u32 pupd_bit:6; -

[PATCH] pinctrl: tegra: use signed bitfields for optional fields

2015-03-14 Thread Stefan Agner
Optional fields are set to -1 by various preprocessor macros. Make sure the struct fields can actually store them. Signed-off-by: Stefan Agner --- This lead to a lot of warnings when compiling the Tegra pinctrl drivers using LLVM/clang: drivers/pinctrl/pinctrl-tegra124.c:2048:2: warning: implici