Re: [PATCH] pinctrl: rza1: off by one in rza1_parse_gpiochip()

2017-08-31 Thread Linus Walleij
On Fri, Aug 18, 2017 at 12:32 PM, Dan Carpenter wrote: > The rza1_pctl->ports[] array has RZA1_NPORTS (12) elements. The > here > should be >= to prevent an out of bounds access. > > Fixes: 5a49b644b307 ("pinctrl: Renesas RZ/A1 pin and gpio controller") > Signed-off-by: Dan Carpenter Patch app

Re: [PATCH] pinctrl: rza1: off by one in rza1_parse_gpiochip()

2017-08-23 Thread jmondi
Hi Linus, sorry for being late. With Geert's approval I guess my ack is not that necessary, but... On Wed, Aug 23, 2017 at 09:35:42AM +0200, Geert Uytterhoeven wrote: > On Fri, Aug 18, 2017 at 12:32 PM, Dan Carpenter > wrote: > > The rza1_pctl->ports[] array has RZA1_NPORTS (12) elements. Th

Re: [PATCH] pinctrl: rza1: off by one in rza1_parse_gpiochip()

2017-08-23 Thread Geert Uytterhoeven
On Fri, Aug 18, 2017 at 12:32 PM, Dan Carpenter wrote: > The rza1_pctl->ports[] array has RZA1_NPORTS (12) elements. The > here > should be >= to prevent an out of bounds access. > > Fixes: 5a49b644b307 ("pinctrl: Renesas RZ/A1 pin and gpio controller") > Signed-off-by: Dan Carpenter Reviewed-b

Re: [PATCH] pinctrl: rza1: off by one in rza1_parse_gpiochip()

2017-08-23 Thread Linus Walleij
On Fri, Aug 18, 2017 at 12:32 PM, Dan Carpenter wrote: > The rza1_pctl->ports[] array has RZA1_NPORTS (12) elements. The > here > should be >= to prevent an out of bounds access. > > Fixes: 5a49b644b307 ("pinctrl: Renesas RZ/A1 pin and gpio controller") > Signed-off-by: Dan Carpenter > > diff -

[PATCH] pinctrl: rza1: off by one in rza1_parse_gpiochip()

2017-08-18 Thread Dan Carpenter
The rza1_pctl->ports[] array has RZA1_NPORTS (12) elements. The > here should be >= to prevent an out of bounds access. Fixes: 5a49b644b307 ("pinctrl: Renesas RZ/A1 pin and gpio controller") Signed-off-by: Dan Carpenter diff --git a/drivers/pinctrl/pinctrl-rza1.c b/drivers/pinctrl/pinctrl-rza1.