Re: [PATCH] pinctrl: rockchip: fix pull setting error for rk3399

2016-05-10 Thread Caesar Wang
Doug, 于 2016年05月11日 05:07, Doug Anderson 写道: Caesar / David, On Tue, May 10, 2016 at 4:14 AM, Caesar Wang wrote: From: David Wu This patch fixes the pinctrl pull bias setting, since the pull up/down setting is the contrary for gpio0. Commit message only mentions gpio0, but gpio2 is also fi

Re: [PATCH] pinctrl: rockchip: fix pull setting error for rk3399

2016-05-10 Thread Doug Anderson
Caesar / David, On Tue, May 10, 2016 at 4:14 AM, Caesar Wang wrote: > From: David Wu > > This patch fixes the pinctrl pull bias setting, since the pull up/down > setting is the contrary for gpio0. Commit message only mentions gpio0, but gpio2 is also fixed in the commit. Please mention gpio2 i

[PATCH] pinctrl: rockchip: fix pull setting error for rk3399

2016-05-10 Thread Caesar Wang
From: David Wu This patch fixes the pinctrl pull bias setting, since the pull up/down setting is the contrary for gpio0. >From the TRM said, the gpio0 pull polarity setting: gpio0a_p (gpio0 ) GPIO0A PE/PS programmation section, every GPIO bit corresponding to 2bits[PS:PE] 2'b00: Z(Noraml operato