Re: [PATCH] pinctrl: mcp23s08: fix irq setup order

2018-01-07 Thread Phil Reid
On 2/01/2018 17:10, Linus Walleij wrote: On Thu, Dec 28, 2017 at 4:19 PM, Dmitry Mastykin wrote: When using mcp23s08 module with gpio-keys, often (50% of boots) it fails to get irq numbers with message: "gpio-keys keys: Unable to get irq number for GPIO 0, error -6". Seems that irqs must be se

Re: [PATCH] pinctrl: mcp23s08: fix irq setup order

2018-01-03 Thread Dmitry Mastykin
On Tue, Jan 2, 2018 at 12:10 PM, Linus Walleij wrote: > > Patch applied, albeit for devel. > > Should it be tagged for stable or go into fixes? > Thank you very much, Linus! About tags, please do as it convenient for you. Kind regards, Dmitry > On Thu, Dec 28, 2017 at 4:19 PM, Dmitry Mastykin w

Re: [PATCH] pinctrl: mcp23s08: fix irq setup order

2018-01-02 Thread Linus Walleij
On Thu, Dec 28, 2017 at 4:19 PM, Dmitry Mastykin wrote: > When using mcp23s08 module with gpio-keys, often (50% of boots) > it fails to get irq numbers with message: > "gpio-keys keys: Unable to get irq number for GPIO 0, error -6". > Seems that irqs must be setup before devm_gpiochip_add_data().

[PATCH] pinctrl: mcp23s08: fix irq setup order

2017-12-28 Thread Dmitry Mastykin
When using mcp23s08 module with gpio-keys, often (50% of boots) it fails to get irq numbers with message: "gpio-keys keys: Unable to get irq number for GPIO 0, error -6". Seems that irqs must be setup before devm_gpiochip_add_data(). Signed-off-by: Dmitry Mastykin --- drivers/pinctrl/pinctrl-mcp