Re: [PATCH] pinctrl: imx: make sure that maps are fully initialized

2018-11-12 Thread Martin Kaiser
Hi Leonard, Thus wrote Leonard Crestez (leonard.cres...@nxp.com): > On 11/10/18 7:37 PM, Martin Kaiser wrote: > > The commit that added scu based pinctrl support introduced a regression > > for the mmio case. In the for-loop where the maps are initialized, we > > end up creating a partially initi

Re: [PATCH] pinctrl: imx: make sure that maps are fully initialized

2018-11-12 Thread Fabio Estevam
Hi Dong, On Mon, Nov 12, 2018 at 1:04 PM A.s. Dong wrote: > Thanks for reporting this issue. > The original code intended to save 3 common lines for both SCU and MMIO pads, > but it did change the code logic a bit which resulted in a regression > specificly > for NO_PAD_CTL cases used on a few

RE: [PATCH] pinctrl: imx: make sure that maps are fully initialized

2018-11-12 Thread A.s. Dong
Hi Martin, > -Original Message- > From: Martin Kaiser [mailto:mar...@kaiser.cx] > Sent: Sunday, November 11, 2018 1:37 AM [...] > > The commit that added scu based pinctrl support introduced a regression for > the mmio case. In the for-loop where the maps are initialized, we end up > crea

Re: [PATCH] pinctrl: imx: make sure that maps are fully initialized

2018-11-11 Thread Leonard Crestez
On 11/10/18 7:37 PM, Martin Kaiser wrote: > The commit that added scu based pinctrl support introduced a regression > for the mmio case. In the for-loop where the maps are initialized, we > end up creating a partially initialized map in some cases. This causes a > kernel panic when such a map is us

Re: [PATCH] pinctrl: imx: make sure that maps are fully initialized

2018-11-10 Thread Fabio Estevam
Hi Martin, On Sat, Nov 10, 2018 at 3:39 PM Martin Kaiser wrote: > > The commit that added scu based pinctrl support introduced a regression > for the mmio case. In the for-loop where the maps are initialized, we > end up creating a partially initialized map in some cases. This causes a > kernel p

[PATCH] pinctrl: imx: make sure that maps are fully initialized

2018-11-10 Thread Martin Kaiser
The commit that added scu based pinctrl support introduced a regression for the mmio case. In the for-loop where the maps are initialized, we end up creating a partially initialized map in some cases. This causes a kernel panic when such a map is used at a later stage. When scu is not used and and