On Thu, Mar 5, 2015 at 12:23 AM, Stefan Agner wrote:
> Do you generally agree to that change?
>
> @Linus Walleij, anything holding this patch back from getting merged?
Nothing apart from me being overloaded.
Merged now, thanks.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the li
On Fri, Feb 6, 2015 at 5:30 PM, Stefan Agner wrote:
> Commit 3dac1918a491 ("pinctrl: imx: detect uninitialized pins") needs
> the values in struct imx_pin_reg to be -1. This has been done in a
> rather unorthodox way by setting the memory to 0xff using memset...
> Use a proper for loop to initial
On 2015-03-02 16:53, Uwe Kleine-König wrote:
> Hello,
>
> On Mon, Mar 02, 2015 at 02:42:01PM +0100, Stefan Agner wrote:
>> On 2015-03-02 13:59, Uwe Kleine-König wrote:
>> > On Mon, Mar 02, 2015 at 07:45:17PM +0800, Shawn Guo wrote:
>> >> On Fri, Feb 06, 2015 at 05:30:56PM +0100, Stefan Agner wrote
Hello,
On Mon, Mar 02, 2015 at 02:42:01PM +0100, Stefan Agner wrote:
> On 2015-03-02 13:59, Uwe Kleine-König wrote:
> > On Mon, Mar 02, 2015 at 07:45:17PM +0800, Shawn Guo wrote:
> >> On Fri, Feb 06, 2015 at 05:30:56PM +0100, Stefan Agner wrote:
> >> > Commit 3dac1918a491 ("pinctrl: imx: detect un
On 2015-03-02 13:59, Uwe Kleine-König wrote:
> Hello Shawn
>
> On Mon, Mar 02, 2015 at 07:45:17PM +0800, Shawn Guo wrote:
>> On Fri, Feb 06, 2015 at 05:30:56PM +0100, Stefan Agner wrote:
>> > Commit 3dac1918a491 ("pinctrl: imx: detect uninitialized pins") needs
>> > the values in struct imx_pin_re
Hello Shawn
On Mon, Mar 02, 2015 at 07:45:17PM +0800, Shawn Guo wrote:
> On Fri, Feb 06, 2015 at 05:30:56PM +0100, Stefan Agner wrote:
> > Commit 3dac1918a491 ("pinctrl: imx: detect uninitialized pins") needs
> > the values in struct imx_pin_reg to be -1. This has been done in a
> > rather unortho
On Fri, Feb 06, 2015 at 05:30:56PM +0100, Stefan Agner wrote:
> Commit 3dac1918a491 ("pinctrl: imx: detect uninitialized pins") needs
> the values in struct imx_pin_reg to be -1. This has been done in a
> rather unorthodox way by setting the memory to 0xff using memset...
> Use a proper for loop to
On 2015-02-06 20:21, Uwe Kleine-König wrote:
> Hallo Stefan,
>
> On Fri, Feb 06, 2015 at 05:30:56PM +0100, Stefan Agner wrote:
>> -memset(info->pin_regs, 0xff, sizeof(*info->pin_regs) * info->npins);
>> +
>> +for (i = 0; i < info->npins; i++) {
>> +info->pin_regs[i].mux_reg = -
Hallo Stefan,
On Fri, Feb 06, 2015 at 05:30:56PM +0100, Stefan Agner wrote:
> - memset(info->pin_regs, 0xff, sizeof(*info->pin_regs) * info->npins);
> +
> + for (i = 0; i < info->npins; i++) {
> + info->pin_regs[i].mux_reg = -1;
> + info->pin_regs[i].conf_reg = -1;
Commit 3dac1918a491 ("pinctrl: imx: detect uninitialized pins") needs
the values in struct imx_pin_reg to be -1. This has been done in a
rather unorthodox way by setting the memory to 0xff using memset...
Use a proper for loop to initialize the whole array with -1.
Signed-off-by: Stefan Agner
---
10 matches
Mail list logo
