Re: [PATCH] pinctrl: bc2835: Add brcm,level property

2018-03-03 Thread Stefan Wahren
Hi Matheus, sorry for my late reply. > Matheus Castello hat am 22. Februar 2018 um 18:44 > geschrieben: > > > Property to set initial value of pin output buffer. > > Signed-off-by: Matheus Castello > --- > .../bindings/pinctrl/brcm,bcm2835-gpio.txt | 5 +- > drivers/pinctrl/bcm/pi

Re: [PATCH] pinctrl: bc2835: Add brcm,level property

2018-03-02 Thread Linus Walleij
Hi Matheus, sorry for top-posting, but new DT properties have to be ACKed by the device tree maintainers, so quoting it all. I understand why you use the legacy bcm-specific bindings for this, but in theory nothing really stops you from just using "output-high" and "output-low" from the generic p

Re: [PATCH] pinctrl: bc2835: Add brcm,level property

2018-02-23 Thread Matheus Castello
Property to set initial value of pin output buffer. This can be useful for configure hardware in overlay files, and in early boot for checking it states in QA sanity tests. This modification maintain the legacy property style, but the idea is to continue working in this driver to implement suppo

Re: [PATCH] pinctrl: bc2835: Add brcm,level property

2018-02-23 Thread Eric Anholt
Matheus Castello writes: > Property to set initial value of pin output buffer. In the commit message, could you expand on the motivation for adding this support? Also, couldn't we reuse some existing pinctrl-bindings.txt generic property? signature.asc Description: PGP signature

[PATCH] pinctrl: bc2835: Add brcm,level property

2018-02-22 Thread Matheus Castello
Property to set initial value of pin output buffer. Signed-off-by: Matheus Castello --- .../bindings/pinctrl/brcm,bcm2835-gpio.txt | 5 +- drivers/pinctrl/bcm/pinctrl-bcm2835.c | 90 +- 2 files changed, 75 insertions(+), 20 deletions(-) diff --git a/Doc