Re: [PATCH] pinctrl: amd: avoid maybe-uninitalized warning

2017-01-12 Thread Shyam Sundar S K
Hi Linus, You have already added patch for the same "[PATCH] pinctrl: amd: fix compilation warning" and applied to one of your fixed branch. Do you feel this patch needs to be taken ? Thanks, Shyam On 1/12/2017 1:19 PM, Linus Walleij wrote: > On Wed, Jan 11, 2017 at 3:36 PM, Arnd Bergmann wro

Re: [PATCH] pinctrl: amd: avoid maybe-uninitalized warning

2017-01-11 Thread Linus Walleij
On Wed, Jan 11, 2017 at 3:36 PM, Arnd Bergmann wrote: > Since gpio_dev->hwbank_num is now a variable, the compiler cannot > figure out if pin_num is initialized at all: > > drivers/pinctrl/pinctrl-amd.c: In function 'amd_gpio_dbg_show': > drivers/pinctrl/pinctrl-amd.c:210:3: warning: 'pin_num' ma

[PATCH] pinctrl: amd: avoid maybe-uninitalized warning

2017-01-11 Thread Arnd Bergmann
Since gpio_dev->hwbank_num is now a variable, the compiler cannot figure out if pin_num is initialized at all: drivers/pinctrl/pinctrl-amd.c: In function 'amd_gpio_dbg_show': drivers/pinctrl/pinctrl-amd.c:210:3: warning: 'pin_num' may be used uninitialized in this function [-Wmaybe-uninitialized]