Re: [PATCH] perf util: Display warning when perf report/annotate is missing some libs

2018-03-23 Thread Jiri Olsa
On Fri, Mar 23, 2018 at 11:50:49AM -0300, Arnaldo Carvalho de Melo wrote: SNIP > > > I just don't like the idea that when you run perf report, > > > or annotate it spits out lines for every missing feature > > > > > > maybe we could detect missing features for given command > > > and display lin

Re: [PATCH] perf util: Display warning when perf report/annotate is missing some libs

2018-03-23 Thread Arnaldo Carvalho de Melo
Em Fri, Mar 23, 2018 at 11:09:03AM +0800, Jin, Yao escreveu: > On 3/22/2018 4:51 PM, Jiri Olsa wrote: > > On Thu, Mar 22, 2018 at 09:04:10AM +0800, Jin, Yao wrote: > > > On 3/21/2018 11:38 PM, Jiri Olsa wrote: > > > > On Wed, Mar 21, 2018 at 10:11:10AM +0800, Jin, Yao wrote: > > > > > Hi Jiri, > >

Re: [PATCH] perf util: Display warning when perf report/annotate is missing some libs

2018-03-22 Thread Jin, Yao
On 3/22/2018 4:51 PM, Jiri Olsa wrote: On Thu, Mar 22, 2018 at 09:04:10AM +0800, Jin, Yao wrote: On 3/21/2018 11:38 PM, Jiri Olsa wrote: On Wed, Mar 21, 2018 at 10:11:10AM +0800, Jin, Yao wrote: Hi Jiri, I'm still thinking it's worth displaying the warning when perf missing some libraries

Re: [PATCH] perf util: Display warning when perf report/annotate is missing some libs

2018-03-22 Thread Jiri Olsa
On Thu, Mar 22, 2018 at 09:04:10AM +0800, Jin, Yao wrote: > > > On 3/21/2018 11:38 PM, Jiri Olsa wrote: > > On Wed, Mar 21, 2018 at 10:11:10AM +0800, Jin, Yao wrote: > > > Hi Jiri, > > > > > > I'm still thinking it's worth displaying the warning when perf missing > > > some > > > libraries. > >

Re: [PATCH] perf util: Display warning when perf report/annotate is missing some libs

2018-03-21 Thread Jin, Yao
On 3/22/2018 2:52 AM, Arnaldo Carvalho de Melo wrote: Em Wed, Mar 21, 2018 at 05:04:46PM +0100, Jiri Olsa escreveu: On Wed, Mar 21, 2018 at 12:43:15PM -0300, Arnaldo Carvalho de Melo wrote: Em Wed, Mar 21, 2018 at 12:40:35PM -0300, Arnaldo Carvalho de Melo escreveu: Em Wed, Mar 21, 2018 at 0

Re: [PATCH] perf util: Display warning when perf report/annotate is missing some libs

2018-03-21 Thread Jin, Yao
On 3/21/2018 11:38 PM, Jiri Olsa wrote: On Wed, Mar 21, 2018 at 10:11:10AM +0800, Jin, Yao wrote: Hi Jiri, I'm still thinking it's worth displaying the warning when perf missing some libraries. Somebody just told me that perf didn't work well. While after some investigations, I found it's ju

Re: [PATCH] perf util: Display warning when perf report/annotate is missing some libs

2018-03-21 Thread Jiri Olsa
On Wed, Mar 21, 2018 at 03:52:37PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Mar 21, 2018 at 05:04:46PM +0100, Jiri Olsa escreveu: > > On Wed, Mar 21, 2018 at 12:43:15PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Wed, Mar 21, 2018 at 12:40:35PM -0300, Arnaldo Carvalho de Melo > > > esc

Re: [PATCH] perf util: Display warning when perf report/annotate is missing some libs

2018-03-21 Thread Arnaldo Carvalho de Melo
Em Wed, Mar 21, 2018 at 05:04:46PM +0100, Jiri Olsa escreveu: > On Wed, Mar 21, 2018 at 12:43:15PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Wed, Mar 21, 2018 at 12:40:35PM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Wed, Mar 21, 2018 at 04:38:07PM +0100, Jiri Olsa escreveu: > > > > On W

Re: [PATCH] perf util: Display warning when perf report/annotate is missing some libs

2018-03-21 Thread Jiri Olsa
On Wed, Mar 21, 2018 at 12:43:15PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Mar 21, 2018 at 12:40:35PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Wed, Mar 21, 2018 at 04:38:07PM +0100, Jiri Olsa escreveu: > > > On Wed, Mar 21, 2018 at 10:11:10AM +0800, Jin, Yao wrote: > > > > Hi Jiri,

Re: [PATCH] perf util: Display warning when perf report/annotate is missing some libs

2018-03-21 Thread Arnaldo Carvalho de Melo
Em Wed, Mar 21, 2018 at 12:43:15PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Mar 21, 2018 at 12:40:35PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Wed, Mar 21, 2018 at 04:38:07PM +0100, Jiri Olsa escreveu: > > > On Wed, Mar 21, 2018 at 10:11:10AM +0800, Jin, Yao wrote: > > > > Hi Ji

Re: [PATCH] perf util: Display warning when perf report/annotate is missing some libs

2018-03-21 Thread Arnaldo Carvalho de Melo
Em Wed, Mar 21, 2018 at 12:40:35PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Mar 21, 2018 at 04:38:07PM +0100, Jiri Olsa escreveu: > > On Wed, Mar 21, 2018 at 10:11:10AM +0800, Jin, Yao wrote: > > > Hi Jiri, > > > > > > I'm still thinking it's worth displaying the warning when perf missi

Re: [PATCH] perf util: Display warning when perf report/annotate is missing some libs

2018-03-21 Thread Arnaldo Carvalho de Melo
Em Wed, Mar 21, 2018 at 04:38:07PM +0100, Jiri Olsa escreveu: > On Wed, Mar 21, 2018 at 10:11:10AM +0800, Jin, Yao wrote: > > Hi Jiri, > > > > I'm still thinking it's worth displaying the warning when perf missing some > > libraries. > > > > Somebody just told me that perf didn't work well. While

Re: [PATCH] perf util: Display warning when perf report/annotate is missing some libs

2018-03-21 Thread Jiri Olsa
On Wed, Mar 21, 2018 at 10:11:10AM +0800, Jin, Yao wrote: > Hi Jiri, > > I'm still thinking it's worth displaying the warning when perf missing some > libraries. > > Somebody just told me that perf didn't work well. While after some > investigations, I found it's just missing some libraries when

Re: [PATCH] perf util: Display warning when perf report/annotate is missing some libs

2018-03-20 Thread Jin, Yao
Hi Jiri, I'm still thinking it's worth displaying the warning when perf missing some libraries. Somebody just told me that perf didn't work well. While after some investigations, I found it's just missing some libraries when building the perf. But I have spent some time on getting the root

Re: [PATCH] perf util: Display warning when perf report/annotate is missing some libs

2018-01-11 Thread Jin, Yao
On 1/11/2018 11:30 PM, Jiri Olsa wrote: On Thu, Jan 11, 2018 at 07:03:06PM +0800, Jin Yao wrote: We keep having bug reports that when users build perf on their own, we already have same warnings during the build Yes, there will be warnings displayed during the build if some libraries are

Re: [PATCH] perf util: Display warning when perf report/annotate is missing some libs

2018-01-11 Thread Jiri Olsa
On Thu, Jan 11, 2018 at 07:03:06PM +0800, Jin Yao wrote: > We keep having bug reports that when users build perf on their own, we already have same warnings during the build > but they don't install some needed libraries like libelf, libbfd/libibery. how about saying that in the symbol column, i

[PATCH] perf util: Display warning when perf report/annotate is missing some libs

2018-01-10 Thread Jin Yao
We keep having bug reports that when users build perf on their own, but they don't install some needed libraries like libelf, libbfd/libibery. The perf can build, but it is missing important functionality. For example, perf report doesn't display any symbols and perf annotate doesn't work. This