Re: [PATCH] perf ui/tui: Show fatal error message only if exists

2015-01-22 Thread Jiri Olsa
On Fri, Jan 23, 2015 at 12:08:34AM +0900, Namhyung Kim wrote: SNIP > > > "Press any key...", 0); > > > > looks like we display ui_helpline__last_msg also in ui/browsers/annotate.c > > Right, I also saw it. > > > > > do we want to have some common function that un

Re: [PATCH] perf ui/tui: Show fatal error message only if exists

2015-01-22 Thread Namhyung Kim
On Tue, Jan 20, 2015 at 01:49:26PM +0100, Jiri Olsa wrote: > On Tue, Jan 20, 2015 at 03:40:50PM +0900, Namhyung Kim wrote: > > When perf exits with some error it shows the error message with > > ui__error() or ui__warning() and then calls ui__exit() during > > exit_browser(). > > > > On TUI, it th

Re: [PATCH] perf ui/tui: Show fatal error message only if exists

2015-01-20 Thread Jiri Olsa
On Tue, Jan 20, 2015 at 03:40:50PM +0900, Namhyung Kim wrote: > When perf exits with some error it shows the error message with > ui__error() or ui__warning() and then calls ui__exit() during > exit_browser(). > > On TUI, it then shows a window titled "Fatal Error" to inform user a > last message

[PATCH] perf ui/tui: Show fatal error message only if exists

2015-01-19 Thread Namhyung Kim
When perf exits with some error it shows the error message with ui__error() or ui__warning() and then calls ui__exit() during exit_browser(). On TUI, it then shows a window titled "Fatal Error" to inform user a last message which might be related with this condition. However it sometimes contains