Re: [PATCH] perf tools: Use tid for finding thread

2014-05-11 Thread Namhyung Kim
On Sun, 11 May 2014 15:15:42 +0200, Jiri Olsa wrote: > On Wed, May 07, 2014 at 11:26:06AM +0900, Namhyung Kim wrote: >> I believe that passing pid (instead of tid) as the 3rd arg of the >> machine__find*_thread() was to find a main thread so that it can >> search proper map group for symbols. Howe

Re: [PATCH] perf tools: Use tid for finding thread

2014-05-11 Thread Jiri Olsa
On Wed, May 07, 2014 at 11:26:06AM +0900, Namhyung Kim wrote: > I believe that passing pid (instead of tid) as the 3rd arg of the > machine__find*_thread() was to find a main thread so that it can > search proper map group for symbols. However with the map sharing > patch applied, it now can do it

Re: [PATCH] perf tools: Use tid for finding thread

2014-05-07 Thread David Ahern
On 5/6/14, 8:26 PM, Namhyung Kim wrote: I believe that passing pid (instead of tid) as the 3rd arg of the machine__find*_thread() was to find a main thread so that it can search proper map group for symbols. However with the map sharing patch applied, it now can do it in any thread. It fixes a

Re: [PATCH] perf tools: Use tid for finding thread

2014-05-07 Thread Stephane Eranian
On Wed, May 7, 2014 at 4:26 AM, Namhyung Kim wrote: > > I believe that passing pid (instead of tid) as the 3rd arg of the > machine__find*_thread() was to find a main thread so that it can > search proper map group for symbols. However with the map sharing > patch applied, it now can do it in any

[PATCH] perf tools: Use tid for finding thread

2014-05-06 Thread Namhyung Kim
I believe that passing pid (instead of tid) as the 3rd arg of the machine__find*_thread() was to find a main thread so that it can search proper map group for symbols. However with the map sharing patch applied, it now can do it in any thread. It fixes a bug when each thread has different name, i