Re: [PATCH] perf tools: Synthesize anon MMAP records on the heap

2014-01-15 Thread Gaurav Jain
Hi Namhyung, > On Jan 15, 2014, at 8:01 PM, "Namhyung Kim" wrote: > > Hi Gaurav, > >> On Wed, 15 Jan 2014 06:44:39 +, Gaurav Jain wrote: >> Hi Namhyung, >> >> >>> On 1/15/14, 12:46 AM, "Namhyung Kim" wrote: >>> diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c >>> index 9b9bd719

Re: [PATCH] perf tools: Synthesize anon MMAP records on the heap

2014-01-15 Thread Namhyung Kim
Hi Don, On Wed, 15 Jan 2014 09:27:27 -0500, Don Zickus wrote: > On Tue, Jan 14, 2014 at 08:48:23PM +, Gaurav Jain wrote: >> On 1/13/14, 11:54 AM, "Don Zickus" wrote: >> >> >On Sat, Jan 11, 2014 at 08:32:14PM -0800, Gaurav Jain wrote: >> >> Anon records usually do not have the 'execname' entr

Re: [PATCH] perf tools: Synthesize anon MMAP records on the heap

2014-01-15 Thread Namhyung Kim
Hi Gaurav, On Wed, 15 Jan 2014 06:44:39 +, Gaurav Jain wrote: > Hi Namhyung, > > > On 1/15/14, 12:46 AM, "Namhyung Kim" wrote: >>Hmm.. so the point is that an executable heap mapping should have >>/tmp/perf-XXX.map as a file name, right? If so, does something like >>below work well for you?

Re: [PATCH] perf tools: Synthesize anon MMAP records on the heap

2014-01-15 Thread Don Zickus
On Tue, Jan 14, 2014 at 08:48:23PM +, Gaurav Jain wrote: > On 1/13/14, 11:54 AM, "Don Zickus" wrote: > > >On Sat, Jan 11, 2014 at 08:32:14PM -0800, Gaurav Jain wrote: > >> Anon records usually do not have the 'execname' entry. However if they > >>are on > >> the heap, the execname shows up as

Re: [PATCH] perf tools: Synthesize anon MMAP records on the heap

2014-01-14 Thread Gaurav Jain
Hi Namhyung, On 1/15/14, 12:46 AM, "Namhyung Kim" wrote: >I'd like to take my ack back - it seems I missed some points. No worries, looks like the patch wasn’t well thought out. >On Tue, 14 Jan 2014 20:48:23 +, Gaurav Jain wrote: >> On 1/13/14, 11:54 AM, "Don Zickus" wrote: >> >>>On Sat,

Re: [PATCH] perf tools: Synthesize anon MMAP records on the heap

2014-01-14 Thread Namhyung Kim
Hi Gaurav, I'd like to take my ack back - it seems I missed some points. On Tue, 14 Jan 2014 20:48:23 +, Gaurav Jain wrote: > On 1/13/14, 11:54 AM, "Don Zickus" wrote: > >>On Sat, Jan 11, 2014 at 08:32:14PM -0800, Gaurav Jain wrote: >>> Anon records usually do not have the 'execname' entry.

Re: [PATCH] perf tools: Synthesize anon MMAP records on the heap

2014-01-14 Thread Gaurav Jain
On 1/13/14, 11:54 AM, "Don Zickus" wrote: >On Sat, Jan 11, 2014 at 08:32:14PM -0800, Gaurav Jain wrote: >> Anon records usually do not have the 'execname' entry. However if they >>are on >> the heap, the execname shows up as '[heap]'. The fix considers any >>executable >> entries in the map that

Re: [PATCH] perf tools: Synthesize anon MMAP records on the heap

2014-01-13 Thread Don Zickus
On Sat, Jan 11, 2014 at 08:32:14PM -0800, Gaurav Jain wrote: > Anon records usually do not have the 'execname' entry. However if they are on > the heap, the execname shows up as '[heap]'. The fix considers any executable > entries in the map that do not have a name or are on the heap as anon record

Re: [PATCH] perf tools: Synthesize anon MMAP records on the heap

2014-01-13 Thread Namhyung Kim
Hi Gaurav, On Sat, 11 Jan 2014 20:32:14 -0800, Gaurav Jain wrote: > Anon records usually do not have the 'execname' entry. However if they are on > the heap, the execname shows up as '[heap]'. The fix considers any executable > entries in the map that do not have a name or are on the heap as anon

[PATCH] perf tools: Synthesize anon MMAP records on the heap

2014-01-11 Thread Gaurav Jain
Anon records usually do not have the 'execname' entry. However if they are on the heap, the execname shows up as '[heap]'. The fix considers any executable entries in the map that do not have a name or are on the heap as anon records and sets the name to '//anon'. This fixes JIT profiling for reco