Re: [PATCH] perf tools: Fix perf_evlist__alloc_mmap() failure path

2016-06-01 Thread Arnaldo Carvalho de Melo
Em Tue, May 31, 2016 at 10:27:43PM +0900, Masami Hiramatsu escreveu: > On Tue, 31 May 2016 13:06:15 + > Wang Nan wrote: > > > If zalloc fail, setting evlist->mmap[i].fd is unsafe. > > perf_evlist__alloc_mmap() should fail right after zalloc() fail. > > Good catch!! > > Reviewed-by: Masami H

Re: [PATCH] perf tools: Fix perf_evlist__alloc_mmap() failure path

2016-05-31 Thread Masami Hiramatsu
On Tue, 31 May 2016 13:06:15 + Wang Nan wrote: > If zalloc fail, setting evlist->mmap[i].fd is unsafe. > perf_evlist__alloc_mmap() should fail right after zalloc() fail. Good catch!! Reviewed-by: Masami Hiramatsu Thanks! > > Signed-off-by: Wang Nan > Cc: Arnaldo Carvalho de Melo > Cc:

[PATCH] perf tools: Fix perf_evlist__alloc_mmap() failure path

2016-05-31 Thread Wang Nan
If zalloc fail, setting evlist->mmap[i].fd is unsafe. perf_evlist__alloc_mmap() should fail right after zalloc() fail. Signed-off-by: Wang Nan Cc: Arnaldo Carvalho de Melo Cc: He Kuang Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Namhyung Kim Cc: Zefan Li Cc: pi3or...@163.com --- tools/perf/util